From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id +FySCXg1U2CUVQAA0tVLHw (envelope-from ) for ; Thu, 18 Mar 2021 11:11:52 +0000 Received: from aspmx2.migadu.com ([2001:41d0:2:c151::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id oOInBXg1U2AbKQAAbx9fmQ (envelope-from ) for ; Thu, 18 Mar 2021 11:11:52 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx2.migadu.com (Postfix) with ESMTPS id 898C79DFF for ; Thu, 18 Mar 2021 12:11:51 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id DB1322757A; Thu, 18 Mar 2021 07:11:46 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 9C23F20019 for ; Thu, 18 Mar 2021 07:11:43 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 76E415FA96; Thu, 18 Mar 2021 07:11:43 -0400 (EDT) Received: (nullmailer pid 1262919 invoked by uid 1000); Thu, 18 Mar 2021 11:11:42 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: Re: [PATCH 04/22] lib: support reopening databases for write access. In-Reply-To: <20210314140217.183425-5-david@tethera.net> References: <20210314140217.183425-1-david@tethera.net> <20210314140217.183425-5-david@tethera.net> Date: Thu, 18 Mar 2021 08:11:42 -0300 Message-ID: <87zgz04sy9.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: ZPHV6LPCOW2GECTYADMGABILH7FOXKZY X-Message-ID-Hash: ZPHV6LPCOW2GECTYADMGABILH7FOXKZY X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1616065911; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=4d70CUy9TlQVFuWzDEzGNhJVaJCGzljGJBU5wXpQWlg=; b=WguIOXaeWreeyWItSuRaDexxpfm/MCL3LpWQrmb5fGENk+CHEW8isjzYxS1eY9H3Jmz9Vw KSk0238jYSdWlpj44hV6iYYKHHD/ixlQgpFyxTpDsfRSY7K8MDbpQSewIvC2ccNnQnB4i2 DmZGiwJhlj1Zsy31Fv8+ERXWTSo7mwRZwqF6BANJxl8hgVq4su8AqUuPYBzQzPMsMO2LUF Ae9ugOitHohIj7hSmhFqisffKkz9LICZkprkBzvmrGaK/uFgW/jQE0Q4R5GsGyxGjLdn6L Y/5TqsKKFaCiXIBMQcvaOcL+kkCeyvr0smSolQdvTG7Bh6VHCKGzMHYKChokBQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1616065911; a=rsa-sha256; cv=none; b=YG+R2SApShAIwsqQ5qwdKeFf/qipq0uUP4mIbEngast/xmTTxoRHSkfKCIzQSNzCa9zXSz 9cIx0pVA1QT8KY5iVVRP0AriNZbJ+eO/2MGuYFtCA7PnJl8o31Bj5rqyVqVmn+ArLHYwUN RVhJCMREFtG0fe8QcoLWzfk4dBdMR9aQj/fMmHSRQU2q/eypBjVNKD+9rPl82XUnEwOsN1 /yUyCRXIWYbVvGWMARlni1lgxaiI3W1TGr4mgY+KDgn/wzCLc79gg0yCek1tw1GtR8xCbK Pa92/FE9T0U+cVq3FOjQW9GP/LabYOLym0bkQgJ2r5fO74+8MBz1lg05Ovu1Xw== ARC-Authentication-Results: i=1; aspmx2.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx2.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.10 Authentication-Results: aspmx2.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx2.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 898C79DFF X-Spam-Score: -2.10 X-Migadu-Scanner: scn0.migadu.com X-TUID: geIUtDL/0+SA David Bremner writes: > In the future Xapian will apparently support this more conveniently > for the cases other than READ_ONLY => READ_ONLY > > Conceptually this function seems to fit better in lib/open.cc; > database.cc is still large enough that moving the function makes > sense. I have applied the first 4 patches of the series to master, as I need them for a bug fix for pre-new hooks. d