From: David Bremner <david@tethera.net>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] compat: expose canonicalize_file_name to C++
Date: Sat, 17 Apr 2021 11:39:59 -0300 [thread overview]
Message-ID: <87zgxxasao.fsf@tethera.net> (raw)
In-Reply-To: <YHrZQwOF/NnX67D2@danh.dev>
Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
>
> However, I see that lib/open.cc uses g_key_file_get_value from GLib
> already, we may switch to g_canonicalize_file_name then?
>
Yes that could work. I think the treatment of NULL input might need some
extra care with g_canonicalize_file_name; at least my 5 minute attempt
to do a replacement causes many test failures. Do you want to make a
patch that uses g_canonicalize_file_name? The one other place we use
canonicalize_file_name (not totally coincidentally) also uses glib, so
in principle we could completely eliminate the compat function.
d
next prev parent reply other threads:[~2021-04-17 14:40 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-17 0:18 [PATCH] compat: expose canonicalize_file_name to C++ Đoàn Trần Công Danh
2021-04-17 12:13 ` David Bremner
2021-04-17 12:49 ` Đoàn Trần Công Danh
2021-04-17 14:39 ` David Bremner [this message]
2021-04-18 4:13 ` Đoàn Trần Công Danh
2021-04-18 7:08 ` Tomi Ollila
2021-04-18 10:38 ` Đoàn Trần Công Danh
2021-04-23 17:31 ` David Bremner
2021-04-24 0:29 ` Đoàn Trần Công Danh
2021-04-18 12:48 ` David Bremner
2021-04-18 16:19 ` Tomi Ollila
2021-04-18 16:47 ` Tomi Ollila
2021-04-24 0:57 ` [PATCH v3] compat: rename {,notmuch_}canonicalize_file_name Đoàn Trần Công Danh
2021-04-24 1:01 ` Đoàn Trần Công Danh
2021-04-24 1:05 ` [PATCH v4] " Đoàn Trần Công Danh
2021-04-24 11:43 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zgxxasao.fsf@tethera.net \
--to=david@tethera.net \
--cc=congdanhqx@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).