From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6G4mD1RLqmCYZQAAgWs5BA (envelope-from ) for ; Sun, 23 May 2021 14:32:20 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id WJfTClRLqmAbaQAAB5/wlQ (envelope-from ) for ; Sun, 23 May 2021 12:32:20 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 906B7CB21 for ; Sun, 23 May 2021 14:32:19 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 117C52AB09; Sun, 23 May 2021 08:32:16 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 6494C2A9A9 for ; Sun, 23 May 2021 08:32:13 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 433B65FD25; Sun, 23 May 2021 08:32:13 -0400 (EDT) Received: (nullmailer pid 2478565 invoked by uid 1000); Sun, 23 May 2021 12:32:11 -0000 From: David Bremner To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH 3/3] test: ruby: simplify basic tests In-Reply-To: <20210501120448.484082-4-felipe.contreras@gmail.com> References: <20210501120448.484082-1-felipe.contreras@gmail.com> <20210501120448.484082-4-felipe.contreras@gmail.com> Date: Sun, 23 May 2021 09:32:11 -0300 Message-ID: <87zgwlr5pw.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 5MF2YFSDJW6K5FRFZ55DWUZVM5PIQMQZ X-Message-ID-Hash: 5MF2YFSDJW6K5FRFZ55DWUZVM5PIQMQZ X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Ludovic LANGE , Stefano Zacchiroli X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621773139; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=b/PiqdvZcAxNUHPOlsiU9X8dKWv4Wc6x5Yq0Yv4I9Ac=; b=Kxtg0HqLxTm57xak8+/JU5htvZw9iclNpFMWpUD9X+NyN2ISZyyX4T60dpAzK0EkB8mArj ONXWagmbwTnxePnTUv8++xq/FImLxuTGD/kRNRxxyhYRshynegANjHr615+vA0U9GEkqRF cjqs0YWL48xppVQ2SOg5jRXKpy3wY90OTiRw1Qrnbuoy/e7Br//9MVHhBV3pRiYoiwA70+ 44wMjZPKK5PrMyESR8HD3sqi+xLN6U0lyYva4giV0+rm6ZkqQF1OwS5+iuk72YIewlcqL9 1+ETFvS60hXQVTenfVsVHid8sf+AT3d4BJ45lVPmbUlotHTw2EDu+JR4FW3yIw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621773139; a=rsa-sha256; cv=none; b=hdIxnVY6MRDb4JHwGqD58O60lL4ZSMmMEt9oqawLXypZgYBmkRyGxbpt6x0jiBUeIg2yAE rB2kthea2vxi3GRWytDRRuBfRydB+ZicDwV7MMnVCqu0MzHB2fkNS/A6zMgOSVjxoD9cWs rC2ARVYfW6zf4OgzllYq3Wy8jI1SfpI3Py7TzLzq+Pk83U/iCC7v1wLhf1aTIoMQ5pe7bx tsC58vXC5RK4/rzMBb5IL8y9WSn+dMfUd+G74j/D1kGd+vplVjJAnc6ewc8WsyMfLdwB8z G9yxdVQFY1zQHgWod+cyLaNyubkZAYrd5qW8+DZe3INLv1MQCtm3Y9Pe9wWbVQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.58 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 906B7CB21 X-Spam-Score: -0.58 X-Migadu-Scanner: scn0.migadu.com X-TUID: 2atoywmyb2zH Felipe Contreras writes: > We don't need to check for the order here, that is done in another test. > > Signed-off-by: Felipe Contreras > --- > test/T395-ruby.sh | 12 ++++-------- > 1 file changed, 4 insertions(+), 8 deletions(-) > > diff --git a/test/T395-ruby.sh b/test/T395-ruby.sh > index e828efed..9298bc9e 100755 > --- a/test/T395-ruby.sh > +++ b/test/T395-ruby.sh > @@ -20,21 +20,17 @@ test_ruby() { > } > > test_begin_subtest "compare thread ids" > -notmuch search --sort=oldest-first --output=threads tag:inbox > EXPECTED > +notmuch search --output=threads tag:inbox > EXPECTED > test_ruby <<"EOF" > -q = db.query('tag:inbox') > -q.sort = Notmuch::SORT_OLDEST_FIRST > -q.search_threads.each do |t| > +db.query('tag:inbox').search_threads.each do |t| > puts 'thread:%s' % t.thread_id > end > EOF > Is this assuming that the sort order in the CLI is the same as in the library / bindings? that seems a bit fragile if so. d