From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eNf5C2j+rmD5WwAAgWs5BA (envelope-from ) for ; Thu, 27 May 2021 04:05:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id KEK2B2j+rmAXdQAAB5/wlQ (envelope-from ) for ; Thu, 27 May 2021 02:05:28 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [144.217.243.247]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 6637218A28 for ; Thu, 27 May 2021 04:05:27 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 2F0E6271D6; Wed, 26 May 2021 22:05:23 -0400 (EDT) Received: from che.mayfirst.org (unknown [162.247.75.117]) by mail.notmuchmail.org (Postfix) with ESMTPS id C807127185 for ; Wed, 26 May 2021 22:05:20 -0400 (EDT) DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019; t=1622081120; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=lQw9t31ET2gOHX8D5tjr9bc5QOv9cm+ec2Rs39i2Koo=; b=attCQed6pZhQuNUZCLRch2eWd0qbDcZNNofPqdsGMbod0HhHtG0qwa/hDM+901tSrqHBF Nb4keJfseG33H/rAQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=fifthhorseman.net; i=@fifthhorseman.net; q=dns/txt; s=2019rsa; t=1622081120; h=from : to : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=lQw9t31ET2gOHX8D5tjr9bc5QOv9cm+ec2Rs39i2Koo=; b=uGjCfSWVa52NTfHSi/cwDm7ngUnijelnbJ0tLhCR4fMkvdf9btCoWELbiC++F+aRSIf4i /HAAF6zXTrbF6abpwnT7P9Q+52Ml3zUSpzqZTe5wnY935/32fHDJaltCrPCTIFta6xKtWGW e8V3/wB40c2UuMVW+BEz7R7UxeT7w8C3RJ7+91aMSBBYXLsrDcbKW4tKxFHbRm9xsaygwYM DTkbHBjIpEVi3H4cCtb8K77tSSuL6UBGdeJjTKSnpnFBcPX0aVNqmMF/8/aD1CSgCmhA+If g2Lr0o0xfbtGHqLLgAwy9vDJnzpj/jYQZbKkUqJ6P4qNEiQfcpHq/24hU9PA== Received: from fifthhorseman.net (lair.fifthhorseman.net [108.58.6.98]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits)) (No client certificate requested) by che.mayfirst.org (Postfix) with ESMTPSA id 57004F9A5 for ; Wed, 26 May 2021 22:05:20 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id 4CF262049A; Wed, 26 May 2021 22:03:43 -0400 (EDT) From: Daniel Kahn Gillmor To: Notmuch Mail Subject: Re: (wrong-type-argument keymapp notmuch-show-mode-map) in emacs on upgrade to notmuch from master In-Reply-To: <87h7ip2baq.fsf@fifthhorseman.net> References: <87h7ip2baq.fsf@fifthhorseman.net> Autocrypt: addr=dkg@fifthhorseman.net; prefer-encrypt=mutual; keydata= mDMEX+i03xYJKwYBBAHaRw8BAQdACA4xvL/xI5dHedcnkfViyq84doe8zFRid9jW7CC9XBiI0QQf FgoAgwWCX+i03wWJBZ+mAAMLCQcJEOCS6zpcoQ26RxQAAAAAAB4AIHNhbHRAbm90YXRpb25zLnNl cXVvaWEtcGdwLm9yZ/tr8E9NA10HvcAVlSxnox6z62KXCInWjZaiBIlgX6O5AxUKCAKbAQIeARYh BMKfigwB81402BaqXOCS6zpcoQ26AADZHQD/Zx9nc3N2kj13AUsKMr/7zekBtgfSIGB3hRCU74Su G44A/34Yp6IAkndewLxb1WdRSokycnaCVyrk0nb4imeAYyoPtBc8ZGtnQGZpZnRoaG9yc2VtYW4u bmV0PojRBBMWCgCDBYJf6LTfBYkFn6YAAwsJBwkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3Rh dGlvbnMuc2VxdW9pYS1wZ3Aub3JnL0Gwxvypz2tu1IPG+yu1zPjkiZwpscsitwrVvzN3bbADFQoI ApsBAh4BFiEEwp+KDAHzXjTYFqpc4JLrOlyhDboAAPkXAP0Z29z7jW+YzLzPTQML4EQLMbkHOfU4 +s+ki81Czt0WqgD/SJ8RyrqDCtEP8+E4ZSR01ysKqh+MUAsTaJlzZjehiQ24MwRf6LTfFgkrBgEE AdpHDwEBB0DkKHOW2kmqfAK461+acQ49gc2Z6VoXMChRqobGP0ubb4kBiAQYFgoBOgWCX+i03wWJ BZ+mAAkQ4JLrOlyhDbpHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3Jnfvo+ nHoxDwaLaJD8XZuXiaqBNZtIGXIypF1udBBRoc0CmwICHgG+oAQZFgoAbwWCX+i03wkQPp1xc3He VlxHFAAAAAAAHgAgc2FsdEBub3RhdGlvbnMuc2VxdW9pYS1wZ3Aub3JnaheiqE7Pfi3Atb3GGTw+ jFcBGOaobgzEJrhEuFpXREEWIQQttUkcnfDcj0MoY88+nXFzcd5WXAAAvrsBAIJ5sBg8Udocv25N stN/zWOiYpnjjvOjVMLH4fV3pWE1AP9T6hzHz7hRnAA8d01vqoxOlQ3O6cb/kFYAjqx3oMXSBhYh BMKfigwB81402BaqXOCS6zpcoQ26AADX7gD/b83VObe14xrNP8xcltRrBZF5OE1rQSPkMNy+eWpk eCwA/1hxiS8ZxL5/elNjXiWuHXEvUGnRoVj745Vl48sZPVYMuDgEX+i03xIKKwYBBAGXVQEFAQEH QIGex1WZbH6xhUBve5mblScGYU+Y8QJOomXH+rr5tMsMAwEICYjJBBgWCgB7BYJf6LTfBYkFn6YA CRDgkus6XKENukcUAAAAAAAeACBzYWx0QG5vdGF0aW9ucy5zZXF1b2lhLXBncC5vcmcEAx9vTD3b J0SXkhvcRcCr6uIDJwic3KFKxkH1m4QW0QKbDAIeARYhBMKfigwB81402BaqXOCS6zpcoQ26AAAX mwD8CWmukxwskU82RZLMk5fm1wCgMB5z8dA50KLw3rgsCykBAKg1w/Y7XpBS3SlXEegIg1K1e6dR fRxL7Z37WZXoH8AH Date: Wed, 26 May 2021 22:03:42 -0400 Message-ID: <87zgwhvsox.fsf@fifthhorseman.net> MIME-Version: 1.0 Message-ID-Hash: E3LZODFG7HIG6AEOEPYDDYHVGBT2CFZP X-Message-ID-Hash: E3LZODFG7HIG6AEOEPYDDYHVGBT2CFZP X-MailFrom: dkg@fifthhorseman.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: multipart/mixed; boundary="===============7559739506701807793==" X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1622081127; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post:dkim-signature:autocrypt:autocrypt; bh=llVhIQDxLdCDC5Rgyu7BuM58sTvzQjRwd/jOeCoRHpw=; b=M9bo+oC197rR3R/ragBrWBns4VePZHLTQFknwdSpWjUdJ/nXZOHQF07K2ZKePAbB2yxmIy /3oRx8627A6qoIt8VnCCfrgYzRatmW9VVaF1yVp/nsdrbWBZRMxlu7KIZc38eo8io11lyE u/A6rho3CgYSB8CS5PPil3mWWlEnZoFuDLtfc75O+O90M8trwJ59dRWM1qdBf0x1QrWjJd Oquy0ZFKWd8CwLNUa08Gqy7ZpKp2DThTh34uhe0puPDBN8B0oVEdssE/Ya4Ptgp4wYz1TM 9V3E34Hb82jvVW1TrVNtC9CQYDeczD5s24Gzb7mXusAse5b/at0nyO9L7qziFg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1622081127; a=rsa-sha256; cv=none; b=jSt/dRpJ9IM4VGJN7VVP3X0ls0QmMjWDkQXz1zF2L+9PfeKKI5Peqesp/Y3kiOt3GXoUn3 c2r8ECRDjE4ovP9Q3QoCtxvv4qsEU2Zbus+c2bJNoUeLBUXjElkT5KhDK8N0oirw4vKwAc b/gpmQ2q5FGqkBpxSoFPEJmbGy0xqPVLpqIT2Tw+qGYhBBzqf8jIVt7+85M1DgmaNKhehN YaC5tnjWafr7zZQi1xkG5qqt76ZXB+q7gqi9Q3TMFLifBTL6uxXWws8Uqa3jnh88jwqLLk nWzwCQpDINtcXbKMK9zhY1v34INFG26XW8WCLws8b8kd1BMjQ1hRXq9YH6BfOw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=fifthhorseman.net header.s=2019 header.b=attCQed6; dkim=fail ("body hash did not verify") header.d=fifthhorseman.net header.s=2019rsa header.b=uGjCfSWV; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -1.54 Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=fifthhorseman.net header.s=2019 header.b=attCQed6; dkim=fail ("body hash did not verify") header.d=fifthhorseman.net header.s=2019rsa header.b=uGjCfSWV; dmarc=fail reason="SPF not aligned (relaxed)" header.from=fifthhorseman.net (policy=none); spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 144.217.243.247 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 6637218A28 X-Spam-Score: -1.54 X-Migadu-Scanner: scn0.migadu.com X-TUID: bPHOgmgYdkwU --===============7559739506701807793== Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable On Wed 2021-05-26 21:52:13 -0400, Daniel Kahn Gillmor wrote: > I'll try downgrading again to see what's replicable, but i'm kind of > confused by this, as it's been working for years. I don't have any problem with 0.31.4-1, but the problem is present with 0.32.1-1 from experimental. In all cases, i'm upgrading notmuch, libnotmuch*, and elpa-notmuch in lockstep. Nothing in NEWS between these versions suggests that my way of binding keys is now deprecated. I worry that this is due to one of the two following commits but my elisp-foo is weak enough that i don't know what the right next steps are: commit adfded9ed0a5a4b06886f462314cd4511cb72d47 Author: Jonas Bernoulli Date: Mon Nov 16 22:28:42 2020 +0100 emacs: avoid binding unnamed commands in keymaps =20=20=20=20 One should never bind unnamed commands in keymaps because doing that makes it needlessly hard for users to change these bindings. =20=20=20=20 Replace such anonymous bindings with named commands that are generated using macros and some boilerplate. Using macros is better than using a simple loop because that makes it possible for `find-function' to find the definitions. Eat your boilerplate--it forms character. =20=20=20=20 Admittedly this approach is quite ugly and it might be better to teach the original commands to support different buffers directly instead of requiring wrapper commands to do just that. =20=20=20=20 Never-the-less as a short-term solution this is better than what we had before. commit 05a436f730cf6277c403b445bca9419ea89a7b2d Author: Jonas Bernoulli Date: Sun Nov 8 20:02:48 2020 +0100 emacs: don't fset keymaps =20=20=20=20 These keymaps are never invoked as commands so the function definitions serve no purpose. Regards, --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iHUEARYIAB0WIQQttUkcnfDcj0MoY88+nXFzcd5WXAUCYK79/gAKCRA+nXFzcd5W XIc0AQCEoSsT3jrTVvoNL99s9RPdJC5d0p1lTrGVxRBORirPNQEA2lrg5h2WF/eU vfwfKhHaGN4JvduveREctx+Wh1A0YAY= =t8/K -----END PGP SIGNATURE----- --=-=-=-- --===============7559739506701807793== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline --===============7559739506701807793==--