unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Jose Antonio Ortega Ruiz <jao@gnu.org>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH 3/7] emacs/tree: command to toggle search sort order in tree mode
Date: Sat, 26 Jun 2021 16:38:07 +0100	[thread overview]
Message-ID: <87zgvcljq8.fsf@gnus.jao.io> (raw)
In-Reply-To: <87h7hkhq7h.fsf@tethera.net>

On Sat, Jun 26 2021, David Bremner wrote:

> jao <jao@gnu.org> writes:
>
>> New command notmuch-tree-toggle-order for switching the sort order (by
>> reissuing the search with a different flag) in a notmuch-tree buffer.
>> ---
>>  emacs/notmuch-tree.el | 14 +++++++++++++-
>>  1 file changed, 13 insertions(+), 1 deletion(-)
>>
>> diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el
>> index 6ef8e439..c23dacfc 100644
>> --- a/emacs/notmuch-tree.el
>> +++ b/emacs/notmuch-tree.el
>> @@ -322,6 +322,7 @@ then NAME behaves like CMD."
>>      ;; that additionally close the message window.
>>      (define-key map [remap notmuch-bury-or-kill-this-buffer] 'notmuch-tree-quit)
>>      (define-key map [remap notmuch-search]       'notmuch-tree-to-search)
>> +    (define-key map [remap notmuch-search]       'notmuch-tree-toggle-order)
>>      (define-key map [remap notmuch-help]         'notmuch-tree-help)
>>      (define-key map [remap notmuch-mua-new-mail] 'notmuch-tree-new-mail)
>>      (define-key map [remap notmuch-jump-search]  'notmuch-tree-jump-search)
>
> That remap command looks like a copy-paste failure. Does it actually
> work?

it was a copy-paste failure, yes. it's fixed in patch 7.

  reply	other threads:[~2021-06-26 15:38 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-26  2:28 New --sort for notmuch show and using it in emacs notmuch-tree-mode jao
2021-06-26  2:28 ` [PATCH 1/7] CLI/show: accept --sort jao
2021-06-26  2:28 ` [PATCH 2/7] emacs/hello: honouring :sort-order in threaded queries jao
2021-06-26  2:28 ` [PATCH 3/7] emacs/tree: command to toggle search sort order in tree mode jao
2021-06-26 10:31   ` David Bremner
2021-06-26 15:38     ` Jose Antonio Ortega Ruiz [this message]
2021-06-26  2:28 ` [PATCH 4/7] doc: updates for new --sort and related emacs commands jao
2021-06-26 10:36   ` David Bremner
2021-06-26  2:28 ` [PATCH 5/7] CLI/show: tests for the new --sort option jao
2021-06-26  2:28 ` [PATCH 6/7] doc: clarifications for the new --sort flag and emacs command jao
2021-06-26  2:28 ` [PATCH 7/7] emacs: fix notmuch-tree-toggle-order keybinding jao
2021-06-26 10:41   ` David Bremner
2021-06-26 10:46     ` David Bremner
2021-06-26 15:41       ` Jose Antonio Ortega Ruiz
2021-06-26 16:55         ` Jose Antonio Ortega Ruiz
2021-06-26 17:42           ` David Bremner
2021-06-26 18:08             ` Jose Antonio Ortega Ruiz
2021-06-26 18:02 ` [PATCH 1/5] CLI/show: accept --sort jao
2021-06-26 18:06 ` Here's a re-roll, with review comments so far addressed jao
2021-06-26 18:06   ` [PATCH 1/5] CLI/show: accept --sort jao
2021-06-26 18:06   ` [PATCH 2/5] CLI/show: tests for the new --sort option jao
2021-06-26 18:06   ` [PATCH 3/5] emacs/hello: honouring :sort-order in threaded queries jao
2021-06-26 18:06   ` [PATCH 4/5] emacs/tree: command to toggle search sort order in tree mode jao
2021-06-26 18:06   ` [PATCH 5/5] doc: new notmuch show --sort and related emacs commands jao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zgvcljq8.fsf@gnus.jao.io \
    --to=jao@gnu.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).