From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id oF+eG0dhbWLZNgEAbAwnHQ (envelope-from ) for ; Sat, 30 Apr 2022 18:18:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id ADKpGkdhbWL1MAAAG6o9tA (envelope-from ) for ; Sat, 30 Apr 2022 18:18:15 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id CBD352B16F for ; Sat, 30 Apr 2022 18:18:14 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 1B24A5F73C; Sat, 30 Apr 2022 16:18:12 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id C9E5D5F6C1 for ; Sat, 30 Apr 2022 16:18:09 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 3A6CF5FBD7; Sat, 30 Apr 2022 12:18:08 -0400 (EDT) Received: (nullmailer pid 1931803 invoked by uid 1000); Sat, 30 Apr 2022 16:18:07 -0000 From: David Bremner To: Leo Okawa Ericson , Tomi Ollila , notmuch@notmuchmail.org Subject: Re: [PATCH 1/1] emacs: Make notmuch-show-next-thread return nil on failure In-Reply-To: <87pmkz4zeq.fsf@relevant-information.com> References: <20220428101217.23844-1-git@relevant-information.com> <20220428101217.23844-2-git@relevant-information.com> <87pmkz4zeq.fsf@relevant-information.com> Date: Sat, 30 Apr 2022 13:18:07 -0300 Message-ID: <87zgk2h7eo.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 2UMUNPDPNJM4VVLE4CZKAWFX2FOSX3GA X-Message-ID-Hash: 2UMUNPDPNJM4VVLE4CZKAWFX2FOSX3GA X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-To: larch@yhetil.org X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1651335495; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=3QFNVIhaxdKa+xZv9iUJfL+yvQG++wotxErqJ2Qb0jM=; b=EOfx67An63eA3ZW7f3z57D/duig/EHJy30i5MX2b3BA2UIFmGYUkyWdv6Q/mBKVkbhkKFV u95pRlT1L+n3xp7GL4UPXS19kk3OMxjTWPIDvs+TTNsbKKNtq3JETPBJWAxzjvAkVnbKIc 4SAwu8gEtgKhiJ6MSG36ytXJtkSVy989Ei/T65EyVndQVDaW+sr1vX5RCgBKF2ZhYQobbS J+vsR+dH4RhyMqvSK9AMah3MX0q7pjOgz3DyoL/hOuB7OBZUdein4zJAoq3hx7l76X4dGc R01+fKn5PxuyR/FfIfbMkYO17Wn0SPW+CUjVr46vq01ZuXk/+tyzUFYkuyI6lg== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1651335495; a=rsa-sha256; cv=none; b=QEe/0fQo2IZKZlJAqrHFENkP4FEZ2kaOZG0N5OyJqpiQ3ihHLszCZUrj+4ebVIZ3KC6cVL 4LOHsXMZjX/aCXBsmgJ7pVNr6rGfhGKDKcIW8SrZeNfvhgUrWB77B9CGm/mut3P5ErJBCy /NEifa8PF1CMzeJ63vMVWV/ku6Vl37HrqvhvMgSd/PUZQC3fQQkRWw2liygZ3VBFfDqMji pyzbI8Vp3B+3UpUycA5W7LhqC9RrWvwMIsxyWiXb6Dws21WL8COpPK7bGC8dduJg37Qq3c gdqvvsr5ttWH276bgls0KbtA2/dIordIJSjgQnkIhXzyUkQyDl8/p+v8EFdn4g== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.35 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: CBD352B16F X-Spam-Score: -2.35 X-Migadu-Scanner: scn0.migadu.com X-TUID: mQxxCA+bv1hO Leo Okawa Ericson writes: > Tomi Ollila writes: > >> >> I don't see why this indentation change is happening... >> > > I thought the indentation was inconsistent with the rest of the file. I > tried running the auto-indenter on a other more complex functions which > changed nothing, but it did change it on this function so I assumed it > was good to include it. If it's bad etiquette, wrong or unnecessary I'm happy > to amend the patch. In general indentation (and whitespace) cleanup is fine, but should be seperate commits labelled as such. d