From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp12.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id sEBFEKlxJWQ7HAAASxT56A (envelope-from ) for ; Thu, 30 Mar 2023 13:25:29 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp12.migadu.com with LMTPS id uFDTD6lxJWQOXgEAauVa8A (envelope-from ) for ; Thu, 30 Mar 2023 13:25:29 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 0DC962875F for ; Thu, 30 Mar 2023 13:25:29 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 5E6DF5F835; Thu, 30 Mar 2023 11:25:26 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id B66F95F802 for ; Thu, 30 Mar 2023 11:25:22 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id EEF695FB82; Thu, 30 Mar 2023 07:25:21 -0400 (EDT) Received: (nullmailer pid 3060955 invoked by uid 1000); Thu, 30 Mar 2023 11:25:20 -0000 From: David Bremner To: Kevin Boulain , notmuch@notmuchmail.org Subject: Re: [PATCH v2 5/5] test: add test for notmuch_message_remove_all_properties_with_prefix In-Reply-To: <20230329161333.154904-5-kevin@boula.in> References: <87v8ij6ben.fsf@tethera.net> <20230329161333.154904-5-kevin@boula.in> Date: Thu, 30 Mar 2023 08:25:20 -0300 Message-ID: <87zg7u4h27.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: E57VED32EOG5ACPD75AILUBLRIMN53O7 X-Message-ID-Hash: E57VED32EOG5ACPD75AILUBLRIMN53O7 X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE X-Migadu-Spam-Score: -4.00 X-Migadu-Scanner: scn1.migadu.com X-Migadu-Queue-Id: 0DC962875F Authentication-Results: aspmx1.migadu.com; none X-Spam-Score: -4.00 X-TUID: bcTi5vKO69KX Kevin Boulain writes: > It wasn't covered, though it shares most of its implementation with > notmuch_message_remove_all_properties. I have applied this series to master, with one commit added in the middle commit 336334996750240608d5f29ed5dd8e40a69c4d79 Author: David Bremner Date: Thu Mar 30 07:56:17 2023 -0300 test: reveal notmuch_message_remove_all_properties as broken Close and re-open the database to show that the removal is not committed to the database. I also had to manually deal with a merge conflict for the last patch, so you might want to double check that. In my next life, I will make more liberal use of backup_database / restore_database, to make the tests in this file less order dependent. d