unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Kevin Boulain <kevin@boula.in>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 5/5] test: add test for notmuch_message_remove_all_properties_with_prefix
Date: Thu, 30 Mar 2023 08:25:20 -0300	[thread overview]
Message-ID: <87zg7u4h27.fsf@tethera.net> (raw)
In-Reply-To: <20230329161333.154904-5-kevin@boula.in>

Kevin Boulain <kevin@boula.in> writes:

> It wasn't covered, though it shares most of its implementation with
> notmuch_message_remove_all_properties.

I have applied this series to master, with one commit added in the
middle

commit 336334996750240608d5f29ed5dd8e40a69c4d79
Author: David Bremner <david@tethera.net>
Date:   Thu Mar 30 07:56:17 2023 -0300

    test: reveal notmuch_message_remove_all_properties as broken
    
    Close and re-open the database to show that the removal is not
    committed to the database.

I also had to manually deal with a merge conflict for the last patch, so
you might want to double check that.

In my next life, I will make more liberal use of backup_database /
restore_database, to make the tests in this file less order dependent.

d

  reply	other threads:[~2023-03-30 11:25 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-03-01 20:51 [PATCH 1/2] test: display key name in property tests Kevin Boulain
2023-03-01 20:51 ` [PATCH 2/2] lib/message-property: sync removed properties to the database Kevin Boulain
2023-03-02 22:39   ` Tomi Ollila
2023-03-02 23:08     ` Kevin Boulain
2023-03-29 11:32       ` David Bremner
2023-03-29 16:13         ` [PATCH v2 1/5] test: display key name in property tests Kevin Boulain
2023-03-29 16:13         ` [PATCH v2 2/5] test: remove unnecessary sorting Kevin Boulain
2023-03-29 16:13         ` [PATCH v2 3/5] test: reorganize tests and mark a few of them as broken Kevin Boulain
2023-03-29 16:13         ` [PATCH v2 4/5] lib/message-property: sync removed properties to the database Kevin Boulain
2023-03-29 16:13         ` [PATCH v2 5/5] test: add test for notmuch_message_remove_all_properties_with_prefix Kevin Boulain
2023-03-30 11:25           ` David Bremner [this message]
2023-03-29 16:23         ` [PATCH 2/2] lib/message-property: sync removed properties to the database Kevin Boulain
2023-03-29 11:33       ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87zg7u4h27.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=kevin@boula.in \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).