* [PATCH] Update documentation of notmuch_query_create
@ 2009-12-05 14:22 Fernando Carrijo
2010-03-09 18:32 ` Carl Worth
0 siblings, 1 reply; 3+ messages in thread
From: Fernando Carrijo @ 2009-12-05 14:22 UTC (permalink / raw)
To: notmuch
Commit cd467caf renamed notmuch_query_search to notmuch_query_search_messages.
Commit 1ba3d46f created notmuch_query_search_threads. We better keep the docs
of notmuch_query_create consistent with those changes.
Signed-off-by: Fernando Carrijo <fcarrijo@yahoo.com.br>
---
lib/notmuch.h | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/lib/notmuch.h b/lib/notmuch.h
index 60834fb..32ab199 100644
--- a/lib/notmuch.h
+++ b/lib/notmuch.h
@@ -305,7 +305,8 @@ notmuch_database_get_all_tags (notmuch_database_t *db);
* result in a query that returns all messages in the database.
*
* See notmuch_query_set_sort for controlling the order of results and
- * notmuch_query_search to actually execute the query.
+ * notmuch_query_search_{messages,threads} to actually execute the
+ * query.
*
* User should call notmuch_query_destroy when finished with this
* query.
--
1.5.6.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] Update documentation of notmuch_query_create
2009-12-05 14:22 [PATCH] Update documentation of notmuch_query_create Fernando Carrijo
@ 2010-03-09 18:32 ` Carl Worth
2010-03-09 22:06 ` Fernando Carrijo
0 siblings, 1 reply; 3+ messages in thread
From: Carl Worth @ 2010-03-09 18:32 UTC (permalink / raw)
To: Fernando Carrijo, notmuch
[-- Attachment #1: Type: text/plain, Size: 872 bytes --]
On Sat, 05 Dec 2009 12:22:05 -0200, Fernando Carrijo <fcarrijo@yahoo.com.br> wrote:
> Commit cd467caf renamed notmuch_query_search to notmuch_query_search_messages.
> Commit 1ba3d46f created notmuch_query_search_threads. We better keep the docs
> of notmuch_query_create consistent with those changes.
Thanks!
I had trouble applying the patch, (perhaps you performed a copy/paste
operation into your email program that added a bunch of trailing
whitespace?). But I fixed that and while at it, edited the comment so
that the full name of each referenced function appears. (The idea being
that I want grep to find these occurrences if they need to be updated
again in the future).
-Carl
[-- Attachment #2: Type: application/pgp-signature, Size: 189 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Update documentation of notmuch_query_create
2010-03-09 18:32 ` Carl Worth
@ 2010-03-09 22:06 ` Fernando Carrijo
0 siblings, 0 replies; 3+ messages in thread
From: Fernando Carrijo @ 2010-03-09 22:06 UTC (permalink / raw)
To: Carl Worth, notmuch
Carl Worth <cworth@cworth.org> wrote:
> On Sat, 05 Dec 2009 12:22:05 -0200, Fernando Carrijo <fcarrijo@yahoo.com.br> wrote:
> > Commit cd467caf renamed notmuch_query_search to notmuch_query_search_messages.
> > Commit 1ba3d46f created notmuch_query_search_threads. We better keep the docs
> > of notmuch_query_create consistent with those changes.
>
> Thanks!
>
> I had trouble applying the patch, (perhaps you performed a copy/paste
> operation into your email program that added a bunch of trailing
> whitespace?).
Sorry for that. At the time I sent the patch I was using, for the lack
of a better euphemism, a memory unconscious mail client which used to
get me distracted from those caracter conversion issues whenever I saw
some other applications being shot by the OOM killer. Seriously.
I won't let it happen again.
> But I fixed that and while at it, edited the comment so
> that the full name of each referenced function appears. (The idea being
> that I want grep to find these occurrences if they need to be updated
> again in the future).
Yes, it makes sense.
> -Carl
Thank you.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-03-09 22:05 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-12-05 14:22 [PATCH] Update documentation of notmuch_query_create Fernando Carrijo
2010-03-09 18:32 ` Carl Worth
2010-03-09 22:06 ` Fernando Carrijo
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).