From: "Sebastian Spaeth" <Sebastian@SSpaeth.de>
To: Carl Worth <cworth@cworth.org>,
Notmuch development list <notmuch@notmuchmail.org>
Subject: Re: Unhandled Xapian exception
Date: Mon, 26 Apr 2010 11:28:07 +0200 [thread overview]
Message-ID: <87y6ga1s2g.fsf@SSpaeth.de> (raw)
In-Reply-To: <87bpd8or04.fsf@yoom.home.cworth.org>
On 2010-04-24, Carl Worth wrote:
> On Fri, 23 Apr 2010 13:21:56 +0200, "Sebastian Spaeth" <Sebastian@SSpaeth.de> wrote:
> > I propose to try..catch this code block and rather than returning VOID
> > it could return NOTMUCH_STATUS_SUCCESS or NOTMUCH_XAPIAN_EXCEPTION.
> > Not sure how "notmuch_database_find_message" would notify the caller of
> > such an exception situation though. The only possible failure value is
> > NULL (which also means did not find such a message).
> And to support that, we would need a different scheme in the
> library. Basically to just document that all calls might throw an
> exception and then not catch and print anything. That would at least be
> much simpler in the library. Then the top-level "notmuch" application
> could just have a C++ wrapper for main() that would catch and print the
> exception message.
I think the python API would not be able to catch a C++ exception at the
library level. I think the proper fix would be to guard the high level
lib/* functions (our public API) and modify the API as needed to notify
us.
E.g for msg* = notmuch_database_find_message(id) (which I used to test
the existence of a message and where NULL can now also mean that someone
modified the database and which renders that test somewhat useless), I
would propose that we make it:
NOTMUCH_STATUS status = notmuch_database_find_message(id, msg*)
where *msg will be filled with the message if it exists and xapian
exceptions are notified through the status code.
Does this make sense?
Sebastian
next prev parent reply other threads:[~2010-04-26 9:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-23 11:21 Unhandled Xapian exception Sebastian Spaeth
2010-04-24 14:38 ` Carl Worth
2010-04-26 9:28 ` Sebastian Spaeth [this message]
2010-04-26 10:57 ` David Edmondson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y6ga1s2g.fsf@SSpaeth.de \
--to=sebastian@sspaeth.de \
--cc=cworth@cworth.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).