unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Pieter Praet <pieter@praet.org>
To: Jameson Rollins <jrollins@finestructure.net>, notmuch@notmuchmail.org
Subject: Re: [PATCH] use custom-face-edit value-type in notmuch-search-line-faces
Date: Tue, 19 Apr 2011 16:46:32 +0200	[thread overview]
Message-ID: <87y6365mev.fsf@A7GMS.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <874o6pm8vx.fsf@servo.finestructure.net>

On Sat, 26 Mar 2011 22:26:26 -0700, Jameson Rollins <jrollins@finestructure.net> wrote:
> On Sat, 26 Mar 2011 22:16:32 -0700, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> > This enables the proper face customization UI for
> > notmuch-search-line-faces.
> 
> Hey, folks.  amdragon was the one who figured out that custom-face-edit
> was the correct value-type to use to get the face customization ui for
> the notmuch-search-line-faces list.  However, he seems to think this
> might not be the right solution.  Austin: care to comment?
> 
> jamie.
Non-text part: application/pgp-signature
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch

No idea why it wouldn't be a good solution, only "negative" thing I
could find was a comment "FIXIT: Use a better equivalent to
custom-face-edit if there is one" in diredful.el:312 [1]

FWIW, in Org-mode (org-todo-keyword-faces @ org-faces.el:355-371 [2],
exactly the same use case) they do it like this:

    :type '(repeat
            (cons
             (string :tag "Keyword")
             (choice :tag "Face   "
              (string :tag "Color")
              (sexp :tag "Face")))))


[1] http://www.emacswiki.org/emacs-en/diredful.el
[2] http://orgmode.org/w/?p=org-mode.git;a=blob;f=lisp/org-faces.el;h=7bb3055c7d707b069ee826dfff54b8e441566e3e;hb=HEAD

  reply	other threads:[~2011-04-19 14:46 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-27  5:16 [PATCH] use custom-face-edit value-type in notmuch-search-line-faces Jameson Graef Rollins
2011-03-27  5:26 ` Jameson Rollins
2011-04-19 14:46   ` Pieter Praet [this message]
2011-04-25 20:52 ` Carl Worth
  -- strict thread matches above, loose matches on Subject: below --
2011-03-28  2:57 Austin Clements
2011-03-28  4:42 ` Jameson Graef Rollins

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y6365mev.fsf@A7GMS.i-did-not-set--mail-host-address--so-tickle-me \
    --to=pieter@praet.org \
    --cc=jrollins@finestructure.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).