unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Carl Worth <cworth@cworth.org>
To: Dirk Hohndel <hohndel@infradead.org>,
	Matthias Guedemann <Matthias.Guedemann@ovgu.de>,
	"notmuch\@notmuchmail.org" <notmuch@notmuchmail.org>
Subject: Re: problems with multipart/mixed
Date: Tue, 24 May 2011 12:50:20 -0700	[thread overview]
Message-ID: <87y61vlvyb.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <m3oc2s95ny.fsf@x201s.gr8dns.org>

[-- Attachment #1: Type: text/plain, Size: 2595 bytes --]

On Mon, 23 May 2011 19:46:41 -0700, Dirk Hohndel <hohndel@infradead.org> wrote:
> Hehe, as the reply below shows... there's still something screwy even
> with the latest git version... in multipart messages things just go
> wrong. Whether I reply (this below should have included your text/plain
> part as quote)

You caught me again, on two points:

	1. Our multipart testing wasn't testing "notmuch reply"

	2. I wasn't actually running the latest code in my own use

I've addressed both of those problems, which made it easy to find and
fix the segfault that was causing the missing data in the reply
buffer. I will hopefully be in a good habit now of creating a Debian
package and installing and using it locally as part of my testing of
major changes.

Meanwhile, I did just push Jameson's recent new-show-part branch (along
with some updates from me). This should complete the big upheaval of
changes to how multipart messages are handled. From here, Jameson will
rebase his crypto branch so we can verify signatures and decrypt
messages within emacs.

> or whether I try to see the html part of a text/plain +
> text/html multipart message...

This is an area where there have been some recent feature changes---and
again, sadly, there's still some missing testing of the emacs features.

The change I am seeing is that previously whenever a message had both a
text/plain part and a corresponding text/html part (withing
multipart/alternative), emacs would render both of them.

Instead, I'm now seeing the text/plain part followed by:

	[ text/html (not shown) ]

As far as that goes, this hiding of the HTML by default is exactly what
I want. (If people don't want this, there's a
notmuch-show-all-multipart/alternative-parts variable that can be
tweaked. Or just do "M-x customize-group notmuch" and find the setting
there.)

Meanwhile, I can imagine that some people might actually need to view
the HTML part that's initially not shown. I just tried hitting 'V' on
the "(not shown)" button and I got several image-viewer windows, each
showing one of the contained images. That's not ideal---it would be
better to get some web browser to display the entire message formatted
correctly.

Maybe that's just something I need to customize on my end, (though, if
so, I think notmuch could do a better job arranging that for the user).

So contributions would be welcome in this area, (both functional
improvements to the emacs interface as well as additional testing of
those emacs features).

-Carl

-- 
carl.d.worth@intel.com

[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]

  reply	other threads:[~2011-05-24 19:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-21  6:35 problems with multipart/mixed Matthias Guedemann
2011-05-23 11:25 ` Dirk Hohndel
2011-05-23 13:39   ` Matthias Guedemann
2011-05-23 21:38     ` Carl Worth
2011-05-24  2:46       ` Dirk Hohndel
2011-05-24 19:50         ` Carl Worth [this message]
2011-05-24 21:01           ` Dirk Hohndel
2011-05-24 22:06             ` Carl Worth

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y61vlvyb.fsf@yoom.home.cworth.org \
    --to=cworth@cworth.org \
    --cc=Matthias.Guedemann@ovgu.de \
    --cc=hohndel@infradead.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).