From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 83B8241445E for ; Sun, 8 Jan 2012 07:08:27 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -1.098 X-Spam-Level: X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yvMwVKlb6Bf4 for ; Sun, 8 Jan 2012 07:08:27 -0800 (PST) Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id C3E3941445D for ; Sun, 8 Jan 2012 07:08:26 -0800 (PST) Received: from smtp.qmul.ac.uk ([138.37.6.40]) by mail2.qmul.ac.uk with esmtp (Exim 4.71) (envelope-from ) id 1RjuM9-0000JH-Tg; Sun, 08 Jan 2012 15:08:22 +0000 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223] helo=localhost) by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69) (envelope-from ) id 1RjuM9-0004Wo-Ka; Sun, 08 Jan 2012 15:08:21 +0000 From: Mark Walters To: Jani Nikula , notmuch@notmuchmail.org, david@tethera.net Subject: Re: [PATCH 1/4] Add the option "--reply-to" to notmuch reply. In-Reply-To: <871urafjiy.fsf@nikula.org> References: <8739btdkir.fsf@qmul.ac.uk> <1325856857-15969-1-git-send-email-markwalters1009@gmail.com> <871urafjiy.fsf@nikula.org> User-Agent: Notmuch/0.10.2+183~g99cd7be (http://notmuchmail.org) Emacs/23.3.1 (i486-pc-linux-gnu) Date: Sun, 08 Jan 2012 15:08:20 +0000 Message-ID: <87y5tiqljv.fsf@qmul.ac.uk> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Sender-Host-Address: 94.192.233.223 X-QM-SPAM-Info: Sender has good ham record. :) X-QM-Body-MD5: b86516ba7f88ce87c7fb30efe38b71eb (of first 20000 bytes) X-SpamAssassin-Score: -1.7 X-SpamAssassin-SpamBar: - X-SpamAssassin-Report: The QM spam filters have analysed this message to determine if it is spam. We require at least 5.0 points to mark a message as spam. This message scored -1.7 points. Summary of the scoring: * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/, * medium trust * [138.37.6.40 listed in list.dnswl.org] * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider * (markwalters1009[at]gmail.com) * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay * domain * 0.6 AWL AWL: From: address is in the auto white-list X-QM-Scan-Virus: ClamAV says the message is clean X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 08 Jan 2012 15:08:27 -0000 On Sun, 08 Jan 2012 14:47:33 +0200, Jani Nikula wrote: > > + /* We add the addresses if we are replying to all or we have not yet found > > + * a non-user address. We have to keep parsing to make sure we do find the > > + * correct from address for the user, but we pass a NULL message > > + */ > > + if ((reply_to_all) || (g_mime_message_get_all_recipients (reply) == NULL)) > > Looking into this, it occurred to me g_mime_message_get_all_recipients() > allocates a new InternetAddressList when the return value is > non-NULL. Thus this leaks memory. OTOH allocating and deallocating for > this purpose seems suboptimal. I'll think this over. If we are happy with reply-to-sender stopping at the to: line (so if you reply-to-sender to an email which you sent and has no-one (apart from possibly you) on the to: line it would not give any recipients) then we only have two cases and we could do something like add_recipients_for_string for reply-to:/from: if return value is non-null then we were the sender so then add_recipients_for_string for to: and then stop regardless (well we want to carry on parsing headers to find the correct from: address to use but not adding any more recipients). It feels a bit hackish (it relies on the fact that if we found our address in the Reply-to:/From: line we didn't find anyone else's address). I think replying to an email which we sent and which does not have any other person on the to: line is sufficiently rare that it doesn't really matter what we do in this case. Best wishes Mark