From: Pieter Praet <pieter@praet.org>
To: David Bremner <david@tethera.net>,
Dmitry Kurochkin <dmitry.kurochkin@gmail.com>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] cli: factor out config handling code to get/set lists.
Date: Thu, 12 Jan 2012 18:26:33 +0100 [thread overview]
Message-ID: <87y5tckf1y.fsf@praet.org> (raw)
In-Reply-To: <87pqft8x4i.fsf@convex-new.cs.unb.ca>
On Mon, 12 Dec 2011 14:26:21 -0400, David Bremner <david@tethera.net> wrote:
> On Sun, 11 Dec 2011 20:41:53 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > Hi David.
> >
> > On Sun, 11 Dec 2011 12:07:51 -0400, David Bremner <david@tethera.net> wrote:
> > > From: David Bremner <bremner@debian.org>
> > >
> > > Two new internal routines are created _config_get_list and
> > > _config_set_list; the notmuch_config_get_* functions that deal with
> > > lists are simply wrappers for these functions.
>
> Updated version pushed. I'm not completely happy with _config_get_list's
> weird API, but I don't have a better idea now.
>
> d
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> http://notmuchmail.org/mailman/listinfo/notmuch
Much cleaner!
However... this would preferrably have been preceded by tests.
Patch follows.
Peace
--
Pieter
next prev parent reply other threads:[~2012-01-12 17:28 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-10 17:50 [RFC PATCH] cli: factor out config handling code to get/set lists David Bremner
2011-12-10 18:24 ` Austin Clements
2011-12-10 20:30 ` David Bremner
2011-12-11 16:07 ` [PATCH] " David Bremner
2011-12-11 16:41 ` Dmitry Kurochkin
2011-12-12 18:26 ` David Bremner
2012-01-12 17:26 ` Pieter Praet [this message]
2012-01-12 17:30 ` [PATCH] test: cli: getting/setting/removing config values Pieter Praet
2012-01-13 3:42 ` David Bremner
2012-01-14 8:54 ` Pieter Praet
2012-01-14 8:57 ` Pieter Praet
2012-01-14 12:16 ` David Bremner
2012-01-16 10:31 ` Pieter Praet
2012-01-16 11:37 ` David Bremner
2012-01-16 16:48 ` Pieter Praet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5tckf1y.fsf@praet.org \
--to=pieter@praet.org \
--cc=david@tethera.net \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).