From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 33605429E54 for ; Mon, 23 Jan 2012 15:08:18 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id uA6j69qmVm0n for ; Mon, 23 Jan 2012 15:08:17 -0800 (PST) Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id 7E73B429E21 for ; Mon, 23 Jan 2012 15:08:17 -0800 (PST) Received: by bkbzt19 with SMTP id zt19so1802957bkb.26 for ; Mon, 23 Jan 2012 15:08:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=Kt3fTuvRfX5pPwEBr2W8Cf1QMGHTZlq0xrlNAVi+RnI=; b=mRzIuDqwuuQqsfNYE1L9Jek2RTulhzttrmvrE0F/HjDaVx/tz3zv6FCcdRuniZQf7Y DNn9mkGTW0GgNR0nOR4ysS/EQdenIMbGGK7QlejwKpziEsTmQ+NGgJJWofslMJ5DAeAA RdxNBXE4rbNnXm0FQfBiNDTxfDaVzL3109LSo= Received: by 10.204.195.130 with SMTP id ec2mr4106769bkb.106.1327360096150; Mon, 23 Jan 2012 15:08:16 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id ek9sm31656239bkb.10.2012.01.23.15.08.14 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 23 Jan 2012 15:08:14 -0800 (PST) From: Dmitry Kurochkin To: Daniel Schoepe , notmuch@notmuchmail.org Subject: Re: [PATCH v7 2/2] emacs: Tests for user-defined sections In-Reply-To: <1327193689-6011-2-git-send-email-daniel@schoepe.org> References: <87d3ac8ta9.fsf@schoepe.localhost> <1327193689-6011-1-git-send-email-daniel@schoepe.org> <1327193689-6011-2-git-send-email-daniel@schoepe.org> User-Agent: Notmuch/0.11+100~gd650abf (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Tue, 24 Jan 2012 03:07:10 +0400 Message-ID: <87y5sym31d.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Daniel Schoepe X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Jan 2012 23:08:18 -0000 Hi Daniel. There are some trailing whitespaces in the tests. Also, please consider moving the hello sections tests to a separate file (emacs-hello-sections, perhaps?). I am worried that test/emacs file becomes too big. And we will probably add more notmuch-hello section-related tests in the future. Regards, Dmitry