unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Daniel Schoepe <daniel@schoepe.org>, notmuch@notmuchmail.org
Cc: Daniel Schoepe <daniel.schoepe@googlemail.com>
Subject: Re: [PATCH v7 2/2] emacs: Tests for user-defined sections
Date: Tue, 24 Jan 2012 03:07:10 +0400	[thread overview]
Message-ID: <87y5sym31d.fsf@gmail.com> (raw)
In-Reply-To: <1327193689-6011-2-git-send-email-daniel@schoepe.org>

Hi Daniel.

There are some trailing whitespaces in the tests.

Also, please consider moving the hello sections tests to a separate file
(emacs-hello-sections, perhaps?).  I am worried that test/emacs file
becomes too big.  And we will probably add more notmuch-hello
section-related tests in the future.

Regards,
  Dmitry

  reply	other threads:[~2012-01-23 23:08 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <id:"1309379221-5617-1-git-send-email-daniel.schoepe@googlemail.com">
2011-07-07 22:53 ` [PATCH v4 0/2] emacs: User-defined sections in notmuch-hello Daniel Schoepe
2011-07-07 22:53   ` [PATCH v4 1/2] " Daniel Schoepe
2011-07-08 23:00     ` Michal Sojka
2011-07-08 23:13       ` Daniel Schoepe
2011-07-09  5:35         ` Michal Sojka
2011-07-09 17:07       ` Daniel Schoepe
2011-07-07 22:53   ` [PATCH v4 2/2] emacs: Tests for user-defined sections Daniel Schoepe
2011-07-09 18:03   ` [PATCH v5 0/2] emacs: User-defined sections in notmuch-hello Daniel Schoepe
2011-07-09 18:03     ` [PATCH v5 1/2] " Daniel Schoepe
2011-07-09 18:03     ` [PATCH v5 2/2] emacs: Tests for user-defined sections Daniel Schoepe
2011-07-11 10:32     ` [PATCH] emacs: NEWS entry " Daniel Schoepe
2011-08-14 16:55     ` [PATCH v5 0/2] emacs: User-defined sections in notmuch-hello Daniel Schoepe
2011-08-15  8:40       ` Michal Sojka
2011-10-10 13:39         ` [PATCH v6 " Daniel Schoepe
2011-10-10 13:39           ` [PATCH v6 1/2] " Daniel Schoepe
2011-11-24 13:54             ` David Bremner
2011-11-24 14:01               ` Daniel Schoepe
2011-11-24 15:43                 ` Michal Sojka
2011-11-28  4:06                 ` Dmitry Kurochkin
2011-11-28  7:57                   ` Michal Sojka
2011-12-14  3:11             ` Dmitry Kurochkin
2011-12-14 12:55               ` Dmitry Kurochkin
2012-01-22  0:39               ` Daniel Schoepe
2012-01-22  0:54                 ` [PATCH v7 " Daniel Schoepe
2012-01-22  0:54                   ` [PATCH v7 2/2] emacs: Tests for user-defined sections Daniel Schoepe
2012-01-23 23:07                     ` Dmitry Kurochkin [this message]
2012-01-28 21:30                       ` Daniel Schoepe
2012-01-28 21:44                         ` [PATCH v8 0/2] emacs: User-defined sections in notmuch-hello Daniel Schoepe
2012-01-28 21:44                           ` [PATCH v8 1/2] " Daniel Schoepe
2012-01-28 21:44                           ` [PATCH v8 2/2] emacs: Tests for user-defined sections Daniel Schoepe
2012-01-28 22:48                         ` [PATCH v7 " Dmitry Kurochkin
2012-01-28 22:54                           ` Daniel Schoepe
2011-10-10 13:39           ` [PATCH v6 " Daniel Schoepe
2011-10-13 14:09           ` [PATCH] emacs-hello: Do not calculate the count of the messages in Michal Sojka
2012-01-16 11:33             ` David Edmondson
2012-01-16 12:39               ` Daniel Schoepe
2012-01-16 10:59           ` [PATCH v6 0/2] emacs: User-defined sections in notmuch-hello David Edmondson
2012-01-16 11:13             ` Daniel Schoepe
2012-02-17  7:48   ` [PATCH v9 " Dmitry Kurochkin
2012-02-17  7:48     ` [PATCH v9 1/2] " Dmitry Kurochkin
2012-02-17  7:48     ` [PATCH v9 2/2] emacs: Tests for user-defined sections Dmitry Kurochkin
2012-02-17 14:48   ` [PATCH v10 0/2] emacs: User-defined sections in notmuch-hello Dmitry Kurochkin
2012-02-17 14:48     ` [PATCH v10 1/2] " Dmitry Kurochkin
2012-03-01 12:36       ` David Bremner
2012-03-01 14:57         ` Michal Sojka
2012-03-01 15:00           ` Dmitry Kurochkin
2012-03-07 19:53         ` Pieter Praet
2012-03-07 20:04           ` Daniel Schoepe
2012-03-07 20:11           ` David Bremner
2012-02-17 14:48     ` [PATCH v10 2/2] emacs: Tests for user-defined sections Dmitry Kurochkin
2012-02-18 22:10     ` [PATCH v10 0/2] emacs: User-defined sections in notmuch-hello Michal Sojka
2012-02-18 22:12       ` [PATCH] emacs-hello: Do not calculate the count of the messages in hidden sections Michal Sojka
2012-03-01 22:18         ` Mark Walters
2012-03-02  0:34           ` Daniel Schoepe
2012-03-02  0:36             ` Daniel Schoepe
2012-03-05  2:00         ` Dmitry Kurochkin
2012-03-10 14:23         ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5sym31d.fsf@gmail.com \
    --to=dmitry.kurochkin@gmail.com \
    --cc=daniel.schoepe@googlemail.com \
    --cc=daniel@schoepe.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).