From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id F0C30431FAF for ; Thu, 26 Jan 2012 09:38:48 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 4o5mNdoT9Efr for ; Thu, 26 Jan 2012 09:38:48 -0800 (PST) Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id D26BE431FAE for ; Thu, 26 Jan 2012 09:38:47 -0800 (PST) Received: by bkbzt19 with SMTP id zt19so782544bkb.26 for ; Thu, 26 Jan 2012 09:38:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:in-reply-to:references:user-agent:date :message-id:mime-version:content-type; bh=ReMARUJ4gzWk4MV6FccgllYy/jiz6t48loU540xRPBk=; b=iIvM7gzK9Ya5rL1StzU5EFWHb/TO5s/pKvTXmdynFNCmIHL8GwUvSHDuJisDNYllXv E9TegGNely0aBhOS/l9rN+vB3jW0+7TnJINRV2A4fLWpTwSDUEBBlUQePdTXhl5F2Hzh bOJrTFmM+vjmhEcJVgXZ/wxQCL2TtmUB3gJgc= Received: by 10.205.128.133 with SMTP id he5mr1480834bkc.17.1327599526492; Thu, 26 Jan 2012 09:38:46 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id z15sm7456782bkd.7.2012.01.26.09.38.45 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 26 Jan 2012 09:38:45 -0800 (PST) From: Dmitry Kurochkin To: Austin Clements Subject: Re: [PATCH v4] emacs: add completion to "tag all" operation ("*" binding) In-Reply-To: <20120126070439.GC1940@mit.edu> References: <1327540351-5249-1-git-send-email-dmitry.kurochkin@gmail.com> <1327554400-7616-1-git-send-email-dmitry.kurochkin@gmail.com> <20120126070439.GC1940@mit.edu> User-Agent: Notmuch/0.11+116~ge6e10b8 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Thu, 26 Jan 2012 21:37:38 +0400 Message-ID: <87y5su8ivx.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 26 Jan 2012 17:38:49 -0000 On Thu, 26 Jan 2012 02:04:39 -0500, Austin Clements wrote: > Quoth Dmitry Kurochkin on Jan 26 at 9:06 am: > > The patch adds completion to "tag all" operation bound to "*" > > (`notmuch-search-operate-all' function). > > --- > > > > On a second thought, `notmuch-select-tag-with-completion' should never > > need `prefixes' argument at all. So I reverted the API and related > > changes. > > > > Changes: > > > > v4: > > > > * do not change `notmuch-select-tag-with-completion' API, revert > > related changes > > > > v3: > > > > * fixed comments from Austin's review [1] > > > > v2: > > > > * s/thistag/this_tag/ for consistency with "that_tag", since we touch > > the line anyway > > > > Regards, > > Dmitry > > > > [1] id:"20120126013727.GB1176@mit.edu" > > > > emacs/notmuch.el | 53 ++++++++++++++++++++++++++++++++++++++++------------- > > 1 files changed, 40 insertions(+), 13 deletions(-) > > > > diff --git a/emacs/notmuch.el b/emacs/notmuch.el > > index e02966f..d2af630 100644 > > --- a/emacs/notmuch.el > > +++ b/emacs/notmuch.el > > @@ -48,6 +48,7 @@ > > ;; required, but is available from http://notmuchmail.org). > > > > (eval-when-compile (require 'cl)) > > +(require 'crm) > > (require 'mm-view) > > (require 'message) > > > > @@ -75,12 +76,36 @@ For example: > > (defvar notmuch-query-history nil > > "Variable to store minibuffer history for notmuch queries") > > > > -(defun notmuch-select-tag-with-completion (prompt &rest search-terms) > > +(defun notmuch-tag-completions (&optional prefixes search-terms) > > (let ((tag-list > > (with-output-to-string > > (with-current-buffer standard-output > > (apply 'call-process notmuch-command nil t nil "search-tags" search-terms))))) > > - (completing-read prompt (split-string tag-list "\n+" t) nil nil nil))) > > + (setq tag-list (split-string tag-list "\n+" t)) > > Since this setq is unconditional, you can do the split-string right in > the let binding, around the with-output-to-string. > I was thinking about it, but decided to use `setq', to make the diff smaller and the let binding simpler. Changed in v5. > > + (if (null prefixes) > > + tag-list > > + (apply #'append > > + (mapcar (lambda (tag) > > + (mapcar (lambda (prefix) > > + (concat prefix tag)) prefixes)) > > + tag-list))))) > > + > > +(defun notmuch-select-tag-with-completion (prompt &rest search-terms) > > + (let ((tag-list (notmuch-tag-completions nil search-terms))) > > + (completing-read prompt tag-list))) > > + > > +(defun notmuch-select-tags-with-completion (prompt &optional prefixes &rest search-terms) > > + (let ((tag-list (notmuch-tag-completions prefixes search-terms)) > > + (crm-separator " ") > > + (crm-local-completion-map > > + (let ((map (make-sparse-keymap))) > > + (set-keymap-parent map crm-local-completion-map) > > + map))) > > + ;; By default, space is bound to "complete word" function. > > + ;; Re-bind it to insert a space instead. Note that still > > + ;; does the completion. > > + (define-key crm-local-completion-map " " 'self-insert-command) > > You could do the define-key inside the (let ((map ..)) ..) so you get > back the fully formed keymap. Your call. > Good point. Changed in v5. > > + (completing-read-multiple prompt tag-list))) > > > > (defun notmuch-foreach-mime-part (function mm-handle) > > (cond ((stringp (car mm-handle)) > > @@ -849,7 +874,7 @@ non-authors is found, assume that all of the authors match." > > (goto-char found-target))) > > (delete-process proc)))) > > > > -(defun notmuch-search-operate-all (action) > > +(defun notmuch-search-operate-all (&rest actions) > > "Add/remove tags from all matching messages. > > > > This command adds or removes tags from all messages matching the > > @@ -860,16 +885,18 @@ will prompt for tags to be added or removed. Tags prefixed with > > Each character of the tag name may consist of alphanumeric > > characters as well as `_.+-'. > > " > > - (interactive "sOperation (+add -drop): notmuch tag ") > > - (let ((action-split (split-string action " +"))) > > - ;; Perform some validation > > - (let ((words action-split)) > > - (when (null words) (error "No operation given")) > > - (while words > > - (unless (string-match-p "^[-+][-+_.[:word:]]+$" (car words)) > > - (error "Action must be of the form `+thistag -that_tag'")) > > - (setq words (cdr words)))) > > - (apply 'notmuch-tag notmuch-search-query-string action-split))) > > + (interactive (notmuch-select-tags-with-completion > > + "Operations (+add -drop): notmuch tag " > > + '("+" "-"))) > > + (setq actions (delete "" actions)) > > Either this line isn't necessary or > notmuch-select-tags-with-completion can do something funny that it > should take care of internally. > It is necessary and it belongs to `notmuch-select-tags-with-completion', thanks. Changed in v5. Regards, Dmitry > > + ;; Perform some validation > > + (let ((words actions)) > > + (when (null words) (error "No operations given")) > > + (while words > > + (unless (string-match-p "^[-+][-+_.[:word:]]+$" (car words)) > > + (error "Action must be of the form `+this_tag' or `-that_tag'")) > > + (setq words (cdr words)))) > > + (apply 'notmuch-tag notmuch-search-query-string actions)) > > > > (defun notmuch-search-buffer-title (query) > > "Returns the title for a buffer with notmuch search results."