From: Mark Walters <markwalters1009@gmail.com>
To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [Patch v2 0/4] Control selection of From: header when replying
Date: Sun, 05 Feb 2012 12:50:49 +0000 [thread overview]
Message-ID: <87y5shv3yu.fsf@qmul.ac.uk> (raw)
In-Reply-To: <87ipjlix6r.fsf@gmail.com>
On Sun, 05 Feb 2012 10:58:04 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> Hi Mark.
>
> I am not sure I like this solution. My concerns are:
>
> * New option looks too complex, too specific.
>
> * There are more aspects of notmuch reply behavior which users would
> like to change (e.g. which part to quote). If we add an option for
> each, we complicate both nomtuch show UI and code.
>
> The problem is that notmuch show output format is too limiting. Instead
> of providing myriad of options for tweaking notmuch show text format
> behavior, we should add JSON format for notmuch reply similar to nomtuch
> show. That would allow notmuch reply to produce structured output with
> required additional information, which should be enough for users to
> construct whatever reply they want.
>
> In this particular case, notmuch reply JSON format could have
> "from-source" attribute that would indicate how it was guessed.
>
> Now the best part. Not so long ago, Adam (in Cc) provided a patch for
> improving nomtuch reply for HTML-only emails. At first he added an
> option for notmuch reply, like you did for from-guessing. I suggested
> him to implement it based on the JSON format instead and he did. AFAIK
> the latest version of his patches is [1]. I did not look at the code
> though. It seems that it is waiting for more review.
>
> So, instead of adding more nomtuch show options, I think a better
> solution is to work with Adam to get the notmuch reply JSON format to
> master and then fix the from-guessing issue by adding an attribute to
> notmuch reply JSON format.
Yes I think you are quite right: this would be a better solution
(particularly as Adam has already done all the hard work!)
Many thanks
Mark
next prev parent reply other threads:[~2012-02-05 12:49 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-04 20:45 [Patch v2 0/4] Control selection of From: header when replying Mark Walters
2012-02-04 20:45 ` [PATCH v2 1/4] cli: add --from option to reply to restrict guessing of the From: header Mark Walters
2012-02-04 22:07 ` Jani Nikula
2012-02-04 20:45 ` [PATCH v2 2/4] cli: update man page for notmuch-reply --from: Mark Walters
2012-02-04 20:45 ` [PATCH v2 3/4] emacs: Improve prompting for user address when replying Mark Walters
2012-02-04 20:45 ` [PATCH v2 4/4] test: test the new --from option to notmuch-reply Mark Walters
2012-02-05 6:58 ` [Patch v2 0/4] Control selection of From: header when replying Dmitry Kurochkin
2012-02-05 12:50 ` Mark Walters [this message]
2012-02-05 13:12 ` Jani Nikula
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5shv3yu.fsf@qmul.ac.uk \
--to=markwalters1009@gmail.com \
--cc=dmitry.kurochkin@gmail.com \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).