From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id 8A72D431FB6 for ; Sat, 18 Feb 2012 23:33:04 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.3 X-Spam-Level: X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id k8yU4d9wewlN for ; Sat, 18 Feb 2012 23:33:03 -0800 (PST) Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36]) by olra.theworths.org (Postfix) with ESMTP id 3B7AD431FAE for ; Sat, 18 Feb 2012 23:33:03 -0800 (PST) Received: from localhost (unknown [192.168.200.4]) by max.feld.cvut.cz (Postfix) with ESMTP id 89CFB19F35DC; Sun, 19 Feb 2012 08:33:02 +0100 (CET) X-Virus-Scanned: IMAP AMAVIS Received: from max.feld.cvut.cz ([192.168.200.1]) by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new, port 10044) with ESMTP id 7rxtwFfqs3HM; Sun, 19 Feb 2012 08:33:01 +0100 (CET) Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34]) by max.feld.cvut.cz (Postfix) with ESMTP id A625419F35D3; Sun, 19 Feb 2012 08:33:01 +0100 (CET) Received: from steelpick.2x.cz (unknown [213.29.198.144]) (Authenticated sender: sojkam1) by imap.feld.cvut.cz (Postfix) with ESMTPSA id 9318A660968; Sun, 19 Feb 2012 08:33:01 +0100 (CET) Received: from wsh by steelpick.2x.cz with local (Exim 4.77) (envelope-from ) id 1Rz1GW-0005AP-OP; Sun, 19 Feb 2012 08:33:00 +0100 From: Michal Sojka To: Jani Nikula Subject: Re: [PATCH] emacs: Mention race condition safety in user visible documentation In-Reply-To: References: <1329605059-15358-1-git-send-email-sojkam1@fel.cvut.cz> User-Agent: Notmuch/0.11.1+210~g5c2fc0a (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sun, 19 Feb 2012 08:33:00 +0100 Message-ID: <87y5rzmg5v.fsf@steelpick.2x.cz> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: notmuch@notmuchmail.org X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 19 Feb 2012 07:33:04 -0000 On Sun, 19 Feb 2012, Jani Nikula wrote: > On Feb 19, 2012 12:44 AM, "Michal Sojka" wrote: > > > > After recent rework of a/A/x/X key bindings, the important paragraph in > > documentation of `notmuch-show-archive-thread' stayed hidden from users, > > because no key is bound to this function. > > > > This patch copies the important paragraph to the documentation of > > functions currently bound to keys. > > Hi Michal, this was discussed earlier, and Dmitry convinced me that the > code does exactly what the user expects it to do (archives only the > messages in the buffer) so it would be unnecessary and confusing to have > this documentation. It could be added as a comment for developers I > guess. I'm not sure. As a developer, I'm used to think about race conditions and the mentioned documentation sounds very racy to me. I guess a lot of other notmuch users are developers who may think the same. > > (defun notmuch-show-archive-thread-then-next () > > - "Archive each message in thread, then show next thread from search." What about changing it to "Archive each message in the current buffer, ..."? -Michal