unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Jameson Graef Rollins <jrollins@finestructure.net>
To: Jani Nikula <jani@nikula.org>,
	Mark Walters <markwalters1009@gmail.com>,
	notmuch@notmuchmail.org
Subject: Re: [PATCH (draft) 0/2] Allow emacs to toggle display of all parts including multipart
Date: Mon, 03 Dec 2012 09:15:21 -0800	[thread overview]
Message-ID: <87y5hf9hw6.fsf@servo.finestructure.net> (raw)
In-Reply-To: <87mwxwme1b.fsf@nikula.org>

[-- Attachment #1: Type: text/plain, Size: 1609 bytes --]

On Sun, Dec 02 2012, Jani Nikula <jani@nikula.org> wrote:
>> The first patch binds this toggle to 't' on the part button. This
>> patch works by itself.
>
> I'd like to rebind RET to do the toggle by default. I don't think it's
> very useful to be able to save multipart/alternative parts by default.

In my opinion RET should always just display the part.  If the part is
inlineable, then it should toggle display of it in the show buffer.  If
it's not, it should open it in an external viewer.  I think that makes
the most sense, and agrees with the behavior of the collapsed citation
text buttons, for instance.

> One more wishlist item, which also doesn't need to be part of this
> series, or by you: I'd like to be able to specify *which*
> multipart/alternative parts should be displayed in addition to
> preferred. A list of (regexps matching) mime types to always open,
> whether they're preferred or not. I've previously sent patches to this
> effect, but they were never merged (I can repost if you want).

I still think that for multipart/alternatives parts we should just cycle
through display of the alternatives.  That's kind of the whole point of
this mime type.  Obviously display everything is better than not being
able to access the alternative parts at all.  But forcing
mutlipart/alternative to behave exactly like multipart/mixed seems to
miss the point to me.

This is something that could be worked off of this series, though, so
definitely don't take this as a mark against this work.  I think this is
a very useful usability improvement.  Thank you for working on it, Mark.

jamie.

[-- Attachment #2: Type: application/pgp-signature, Size: 835 bytes --]

      reply	other threads:[~2012-12-03 17:15 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-10-25  8:09 [PATCH (draft) 0/2] Allow emacs to toggle display of all parts including multipart Mark Walters
2012-10-25  8:09 ` [PATCH (draft) 1/2] emacs: allow the user to toggle the visibility of multipart/alternative parts Mark Walters
2012-10-28  0:08   ` Ethan Glasser-Camp
2012-10-28  8:00     ` Mark Walters
2012-10-25  8:09 ` [PATCH (draft) 2/2] emacs: show: make "view part" show hidden parts Mark Walters
2012-12-02 19:48 ` [PATCH (draft) 0/2] Allow emacs to toggle display of all parts including multipart Jani Nikula
2012-12-03 17:15   ` Jameson Graef Rollins [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5hf9hw6.fsf@servo.finestructure.net \
    --to=jrollins@finestructure.net \
    --cc=jani@nikula.org \
    --cc=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).