From: Jani Nikula <jani@nikula.org>
To: Austin Clements <amdragon@MIT.EDU>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] cli: convert "notmuch new" to the argument parser
Date: Tue, 04 Dec 2012 00:35:46 +0200 [thread overview]
Message-ID: <87y5he9325.fsf@nikula.org> (raw)
In-Reply-To: <20121203222844.GH1020@mit.edu>
On Tue, 04 Dec 2012, Austin Clements <amdragon@MIT.EDU> wrote:
>> - argc--; argv++; /* skip subcommand argument */
>> + notmuch_opt_desc_t options[] = {
>> + { NOTMUCH_OPT_BOOLEAN, &add_files_state.verbose, "verbose", 'v', 0 },
>> + { NOTMUCH_OPT_BOOLEAN, &add_files_state.debug, "debug", 'd', 0 },
>> + { NOTMUCH_OPT_BOOLEAN, &no_hooks, "no-hooks", 'n', 0 },
>
> Not that the single character arguments matter right now, but '-n' is
> often used for "dry-run", which could actually apply to notmuch new.
Agreed, although I believe we'd have to review all of the single
character arguments before actually enabling any of them. At least my
choice of them has been rather whimsical. I'll leave this up to David to
decide.
BR,
Jani.
next prev parent reply other threads:[~2012-12-03 22:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-03 20:56 [PATCH 1/2] cli: fix notmuch top level argument parsing Jani Nikula
2012-12-03 20:56 ` [PATCH 2/2] cli: convert "notmuch new" to the argument parser Jani Nikula
2012-12-03 22:28 ` Austin Clements
2012-12-03 22:35 ` Jani Nikula [this message]
2012-12-03 21:32 ` [PATCH 1/2] cli: fix notmuch top level argument parsing Michal Nazarewicz
2012-12-03 22:17 ` Jani Nikula
2012-12-03 22:30 ` Jani Nikula
2012-12-04 14:00 ` Michal Nazarewicz
2012-12-04 13:16 ` David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5he9325.fsf@nikula.org \
--to=jani@nikula.org \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).