unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH v3 3/5] emacs: show: add invisibility button action
Date: Mon, 17 Dec 2012 08:59:22 -0400	[thread overview]
Message-ID: <87y5gwx2ad.fsf@zancas.localnet> (raw)
In-Reply-To: <1355559338-14313-4-git-send-email-markwalters1009@gmail.com>

Mark Walters <markwalters1009@gmail.com> writes:

> This adds a button action to show hidden parts. In this version "t"
> toggles the visibility of a part. In addition "RET" on a non-shown
> part shows it.

After applying this patch (and the two before it), I get 

emacs-show: Testing emacs notmuch-show view
 FAIL   Hiding Original Message region at beginning of a message
	--- emacs-show.1.OUTPUT	2012-12-17 12:55:01.000000000 +0000
	+++ emacs-show.1.EXPECTED	2012-12-17 12:55:01.000000000 +0000
	@@ -4,5 +4,3 @@
	 Date: Fri, 05 Jan 2001 15:43:57 +0000
	 
	 [ 2-line hidden original message. Click/Enter to show. ]
	------Original Message-----
	-Text here.
nil

I believe this failure exists after applying the full series; I'm just
double checking now.

The problem seems to be specific to emacs24; I'm running 24.2.1

d

  reply	other threads:[~2012-12-17 12:59 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-15  8:15 [PATCH v3 0/5] Use invisibility to toggle display of all parts including multipart Mark Walters
2012-12-15  8:15 ` [PATCH v3 1/5] emacs: show: modify insert-part-header to save the button text Mark Walters
2012-12-15  8:15 ` [PATCH v3 2/5] emacs: show: add overlays for each part Mark Walters
2012-12-15  8:15 ` [PATCH v3 3/5] emacs: show: add invisibility button action Mark Walters
2012-12-17 12:59   ` David Bremner [this message]
2012-12-15  8:15 ` [PATCH v3 4/5] emacs: wash: fix fake-diff part to include msg parameter Mark Walters
2012-12-15  8:15 ` [PATCH v3 5/5] emacs: show: set default show-all-multipart/alternatives to nil Mark Walters
2012-12-15 19:03 ` [PATCH v3 0/5] Use invisibility to toggle display of all parts including multipart Austin Clements

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y5gwx2ad.fsf@zancas.localnet \
    --to=david@tethera.net \
    --cc=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).