From: David Bremner <david@tethera.net>
To: Vladimir Marek <Vladimir.Marek@Oracle.COM>,
Jani Nikula <jani@nikula.org>
Cc: notmuch@notmuchmail.org
Subject: Re: [PATCH] don't store temporary value returned from c_str()
Date: Mon, 29 Apr 2013 18:23:01 -0300 [thread overview]
Message-ID: <87y5c1uj4a.fsf@zancas.localnet> (raw)
In-Reply-To: <20130427160540.GB17459@vi64-x3-2e-prg06.cz.oracle.com>
Vladimir Marek <Vladimir.Marek@Oracle.COM> writes:
>> It's okay to use the result of .c_str() as long as the string object
>> stays in scope, and none of the non-const member functions are
>> called. Here, I think the problem is that TermIterator's overloaded
>> operator*() returns a string object within the if block's scope, and it
>> goes immediately out of scope. You could check this by adding
>
> Right, I overlooked that TermIterator creates temporary string (if I
> understand you correctly).
>
>> fine too.
>
> I would prefer my change as it avoids creating another std::string. At
> least I think.
Would you mind updating your commit message to reflect the best guesses
from this discussion?
d
next prev parent reply other threads:[~2013-04-29 21:23 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-04-19 21:12 [PATCH] don't store temporary value returned from c_str() Vladimir.Marek
2013-04-27 9:33 ` Tomi Ollila
2013-04-27 10:11 ` Vladimir Marek
2013-04-27 11:53 ` David Bremner
2013-04-27 15:59 ` Vladimir Marek
2013-04-30 6:12 ` Kim Minh Kaplan
2013-04-30 8:48 ` Vladimir Marek
2013-04-30 9:44 ` Kim Minh Kaplan
2013-05-01 11:28 ` Vladimir Marek
2013-04-27 12:30 ` Jani Nikula
2013-04-27 13:22 ` Tomi Ollila
2013-04-27 16:05 ` Vladimir Marek
2013-04-29 21:23 ` David Bremner [this message]
2013-05-01 21:33 ` Vladimir Marek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y5c1uj4a.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=Vladimir.Marek@Oracle.COM \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).