From: David Bremner <david@tethera.net>
To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 2/2] cli: define config getters and setters using a macro
Date: Wed, 15 Jan 2014 09:29:24 -0400 [thread overview]
Message-ID: <87y52hidaj.fsf@zancas.localnet> (raw)
In-Reply-To: <1376839205-5115-2-git-send-email-jani@nikula.org>
Jani Nikula <jani@nikula.org> writes:
> There's plenty of duplicated code in defining the functions for config
> get/set. Add macros to define the functions.
>
> ---
>
> This might be a bit too tricky for some people's tastes... let's see!
> ;)
I could go either way on this. I don't find it unbearably tricky; I'm
also not 100% sure it's needed. But if you and Tomi still like the idea,
I'm ok with it.
d
next prev parent reply other threads:[~2014-01-15 13:29 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-18 15:20 [PATCH 1/2] cli: abstract common config get/set code Jani Nikula
2013-08-18 15:20 ` [PATCH 2/2] cli: define config getters and setters using a macro Jani Nikula
2013-08-18 18:09 ` Tomi Ollila
2014-01-15 13:29 ` David Bremner [this message]
2014-01-15 13:24 ` [PATCH 1/2] cli: abstract common config get/set code David Bremner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y52hidaj.fsf@zancas.localnet \
--to=david@tethera.net \
--cc=jani@nikula.org \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).