unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
Subject: Re: [PATCH] dump: make dump take Xapian write lock
Date: Tue, 15 Jul 2014 11:10:51 -0300	[thread overview]
Message-ID: <87y4vuaf10.fsf@maritornes.cs.unb.ca> (raw)
In-Reply-To: <1403554349-8888-1-git-send-email-markwalters1009@gmail.com>

Mark Walters <markwalters1009@gmail.com> writes:

>
> Discussion with Olly on irc indicates that this is currently the best
> solution: in xapian trunk there may be better possibilities using
> snapshots but they need to make it to a release and propogate out to
> users before we can switch approach.

I agree that this seems to be the only feasible approach to make dump
atomic.  I'm a little unsure about the benefits to the end user though.
Currently, the user has to check the return code of dump to ensure it
completed correctly.  With this change, the user will still have to
check that dump did not error out when trying to acquire a write lock.
The following ticket

      http://trac.xapian.org/ticket/275

suggests that if we wanted to a blocking open, we'd be on our own.

Did I miss something here about the benefits? I agree that failing
earlier is nicer, but is that it?

d

  reply	other threads:[~2014-07-15 14:11 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-06  8:03 notmuch dump: taking write-lock to protect from concurrent (cronned) notmuch new? Maarten Aertsen
2014-06-06 11:46 ` Mark Walters
2014-06-12 22:56   ` David Bremner
2014-06-12 23:21     ` Mark Walters
2014-06-23 20:12       ` [PATCH] dump: make dump take Xapian write lock Mark Walters
2014-07-15 14:10         ` David Bremner [this message]
2014-07-16  6:50           ` Mark Walters
2014-07-16 22:36         ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y4vuaf10.fsf@maritornes.cs.unb.ca \
    --to=david@tethera.net \
    --cc=markwalters1009@gmail.com \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).