unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Mark Walters <markwalters1009@gmail.com>
To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH v2 0/2] Allow forwarding of all open messages in the current view.
Date: Sun, 07 Feb 2016 23:57:18 +0000	[thread overview]
Message-ID: <87y4awm5up.fsf@qmul.ac.uk> (raw)
In-Reply-To: <1454792877-7180-1-git-send-email-dme@dme.org>


On Sat, 06 Feb 2016, David Edmondson <dme@dme.org> wrote:
> Allow forwarding of all open messages in the current view.
>
> In response to id:"87fvyhb40x.fsf@alice.fifthhorseman.net".
>
> v2:
> - Use multiple message forwarding to implement single message
>   forwarding.
>

This basically looks good to me. At the moment there is some typo in the
first patch introducing two extra parenthesis at the end of the 
notmuch-mua-new-forward-messages function.

I checked with both message-forward-as-mime true (default giving rfc822
parts) and set to nil (including the messages as plain text) and both
looked as I would expect.

Finally, with this in place it would be very easy to introduce thread
forwarding from search mode. But that can be left until after this.

Best wishes

Mark


>
> David Edmondson (2):
>   emacs: Add `notmuch-show-forward-open-messages'.
>   emacs: `notmuch-show-forward-message' can use
>     `notmuch-mua-new-forward-messages'
>
>  emacs/notmuch-mua.el  | 62 +++++++++++++++++++++++++++++++++++++--------------
>  emacs/notmuch-show.el | 15 +++++++++++--
>  2 files changed, 58 insertions(+), 19 deletions(-)
>
> -- 
> 2.1.4
>
> _______________________________________________
> notmuch mailing list
> notmuch@notmuchmail.org
> https://notmuchmail.org/mailman/listinfo/notmuch

  parent reply	other threads:[~2016-02-07 23:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-06 21:07 [PATCH v2 0/2] Allow forwarding of all open messages in the current view David Edmondson
2016-02-06 21:07 ` [PATCH v2 1/2] emacs: Add `notmuch-show-forward-open-messages' David Edmondson
2016-02-06 21:07 ` [PATCH v2 2/2] emacs: `notmuch-show-forward-message' can use `notmuch-mua-new-forward-messages' David Edmondson
2016-02-07 23:57 ` Mark Walters [this message]
2016-02-08 11:30   ` [PATCH v2 0/2] Allow forwarding of all open messages in the current view David Edmondson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y4awm5up.fsf@qmul.ac.uk \
    --to=markwalters1009@gmail.com \
    --cc=dme@dme.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).