From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 62F786DE00F5 for ; Fri, 15 Jul 2016 00:46:36 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: 0 X-Spam-Level: X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id eLcgFOvBumZK for ; Fri, 15 Jul 2016 00:46:28 -0700 (PDT) Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118]) by arlo.cworth.org (Postfix) with ESMTP id E7EC86DE00C9 for ; Fri, 15 Jul 2016 00:46:27 -0700 (PDT) Received: from fifthhorseman.net (p57A05642.dip0.t-ipconnect.de [87.160.86.66]) by che.mayfirst.org (Postfix) with ESMTPSA id 16BB5F98B; Fri, 15 Jul 2016 03:46:24 -0400 (EDT) Received: by fifthhorseman.net (Postfix, from userid 1000) id B39CD20018; Fri, 15 Jul 2016 09:46:21 +0200 (CEST) From: Daniel Kahn Gillmor To: David Bremner , Notmuch Mail Subject: Re: [PATCH v4 09/16] index encrypted parts when asked. In-Reply-To: <8760s7zr47.fsf@zancas.localnet> References: <1467970047-8013-1-git-send-email-dkg@fifthhorseman.net> <1467970047-8013-10-git-send-email-dkg@fifthhorseman.net> <87lh14e2x8.fsf@tesseract.cs.unb.ca> <8737ncmbpy.fsf@alice.fifthhorseman.net> <8760s7zr47.fsf@zancas.localnet> User-Agent: Notmuch/0.22+77~gaba8744 (https://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu) Date: Fri, 15 Jul 2016 09:46:17 +0200 Message-ID: <87y453jqd2.fsf@alice.fifthhorseman.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 15 Jul 2016 07:46:36 -0000 --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On Fri 2016-07-15 02:23:20 +0200, David Bremner wrote: > - accumulate an error string. With talloc_asprintf_append, this is > not _too_ terrible. Making a second logging function [1] that > didn't clear the log buffer but appended would maybe make sense > (aside from contradicting what I said in the previous message). > This would still need some status return to alert the caller. [...] > [1]: untested: > > void > _notmuch_database_log_append (notmuch_database_t *notmuch, > const char *format, > ...) > { > va_list va_args; > > va_start (va_args, format); > > if (notmuch->status_string) > notmuch->status_string =3D talloc_vasprintf_append (notmuch->status_stri= ng, format, va_args) > else > notmuch->status_string =3D talloc_vasprintf (notmuch, format, va_args); >=20=20=20=20=20 > va_end (va_args); > } If Someone=E2=84=A2 were to publish a changeset with this feature, i'd cert= ainly make use of it in this series. thanks for the suggestion, David. --dkg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJXiJTJXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXRFREIyRTc0RjU2RkNGMkI2NzI5N0I3MzUy NEVDRkY1QUZGNjgzNzBBAAoJECTs/1r/aDcKMk4QAJrzDILjnY48nipIB6tc9o2X w7laaSWgWtYMx4bOMzky4PF8GhprM/ws7vBeTl2G3fVymB5s40nCu071tdmuS15h ZgIKC/71Xj1JG8w9kEZUseEB9sq5bQAoZcOuIM0Te5Nk5THOGFQiLd2EdK5Y24qr QO50ehSvB7mO9Of5Mt3d6BYHtzHDSYx6x3yXMmidx5v5RK1HYcODRpiOh/HniJu5 WYLvU17LNFXrSk0ZXZcrpzedr0/1615E1+1nUjdOvGE88vRakUz34yvrY/hKBWLK dRZybxXskGuw7zz6KICOfB6u9PqbvddSmEiAxWrkRykPSs7jd9rtjG3Uv8q/APFH zFcxVvVY28aCplSBGywjvjwAYFjDDZdHTm5MGAU9463U3aTdkbZGjYP+T1XbaTz+ roB4LsTRsem0DettNF4/sNsUpjrO35PbP53ZzzpgS+RjUwYhxbknQq1W34DQNuoT feZUX+9560avSe6WQu4H5iMgMQeqmRhnxW+vhxEHU0qAxs5t2zQPxwuD5E9A6IEK 0Je7TaTEwMTPuyXNC8YITPi/WN/ylls8X5v4CE1lGf4OWLEwfpLge4H8tfORnp+r NyeF4akrPLC3rolkoxoM6vxIo0jpsEeJWAPxGWsWgjDXH9MpEkRodIS93WqOrR16 nuLxPwe/8IZ0d3arU07E =jkvh -----END PGP SIGNATURE----- --=-=-=--