From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dkg@fifthhorseman.net>
Received: from localhost (localhost [127.0.0.1])
 by arlo.cworth.org (Postfix) with ESMTP id 78BEE6DE2A74
 for <notmuch@notmuchmail.org>; Fri,  7 Jul 2017 15:19:00 -0700 (PDT)
X-Virus-Scanned: Debian amavisd-new at cworth.org
X-Spam-Flag: NO
X-Spam-Score: -0.054
X-Spam-Level: 
X-Spam-Status: No, score=-0.054 tagged_above=-999 required=5
 tests=[AWL=-0.054] autolearn=disabled
Received: from arlo.cworth.org ([127.0.0.1])
 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id acz9Z4Pgeejp for <notmuch@notmuchmail.org>;
 Fri,  7 Jul 2017 15:18:59 -0700 (PDT)
Received: from che.mayfirst.org (che.mayfirst.org [162.247.75.118])
 by arlo.cworth.org (Postfix) with ESMTP id A8C056DE2A22
 for <notmuch@notmuchmail.org>; Fri,  7 Jul 2017 15:18:59 -0700 (PDT)
Received: from fifthhorseman.net (unknown [38.109.115.130])
 by che.mayfirst.org (Postfix) with ESMTPSA id B2F0FF999;
 Fri,  7 Jul 2017 18:18:57 -0400 (EDT)
Received: by fifthhorseman.net (Postfix, from userid 1000)
 id 5A0802092D; Fri,  7 Jul 2017 15:18:55 -0700 (PDT)
From: Daniel Kahn Gillmor <dkg@fifthhorseman.net>
To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org,
 notmuch@freelists.org
Subject: Re: [PATCH 16/23] cli: generalize use of GMIME_SIGNATURE_{ERROR,
 STATUS} to gmime-3
In-Reply-To: <20170603174754.16911-17-david@tethera.net>
References: <20170603174754.16911-1-david@tethera.net>
 <20170603174754.16911-17-david@tethera.net>
Date: Fri, 07 Jul 2017 18:18:55 -0400
Message-ID: <87y3rzzy9c.fsf@fifthhorseman.net>
MIME-Version: 1.0
Content-Type: text/plain
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.23
Precedence: list
List-Id: "Use and development of the notmuch mail system."
 <notmuch.notmuchmail.org>
List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Fri, 07 Jul 2017 22:19:00 -0000

On Sat 2017-06-03 14:47:47 -0300, David Bremner wrote:
> @@ -376,6 +376,33 @@ format_signature_errors (sprinter_t *sp, GMimeSignature *signature)
>  
>      do_format_signature_errors (sp, key_map, ARRAY_SIZE(key_map), errors);
>  }
> +#else
> +static void
> +format_signature_errors (sprinter_t *sp, GMimeSignature *signature)
> +{
> +    GMimeSignatureError errors = g_mime_signature_get_errors (signature);
> +
> +    if (!(errors & GMIME_SIGNATURE_STATUS_ERROR_MASK))
> +	return;
> +
> +    struct {
> +	GMimeSignatureStatus bit;
> +	const char * string;
> +    } key_map[] = {


I think this should be:

 struct key_map_struct key_map

rather than an anonymous struct.

       --dkg