From: Jani Nikula <jani@nikula.org>
To: Jameson Graef Rollins <jrollins@finestructure.net>,
Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
notmuch@notmuchmail.org
Subject: Re: [PATCH] cli: add support for only printing the addresses in notmuch address
Date: Wed, 20 Dec 2017 13:15:06 +0200 [thread overview]
Message-ID: <87y3lxtzut.fsf@nikula.org> (raw)
In-Reply-To: <87wp1hg98f.fsf@ligo.caltech.edu>
On Tue, 19 Dec 2017, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
> On Wed, Dec 20 2017, Jani Nikula <jani@nikula.org> wrote:
>> ~$ notmuch address --output=sender --output=recipients --output=address --output=count id:878tdy8a2q.fsf@ligo.caltech.edu
>> 1 notmuch@notmuchmail.org
>> 1 jrollins@finestructure.net
>> 1 dkg@fifthhorseman.net
>> 1 jani@nikula.org
>>
>> I prefer this to separate options.
>
> Really? If each is just a switch then why not:
>
> ~$ notmuch address --sender --recipients --address --count id:878tdy8a2q.fsf@ligo.caltech.edu
>
> ? It's just shorter, right?
>
> Also, this behavior is quite different than for search, in which only
> the last --output applies.
>
>> notmuch search uses separate --entire-thread, --body, and --include-html
>> options, and I think those are getting messy.
That was supposed to be notmuch show, not search.
> The seem less messy than a "--output=" prefixed version of the same.
Matter of taste. I like the self-documenting aspect of *what* these
options control. --output=body is obvious, --body is less
so. --include-html includes html somewhere, I think --output=html would
be better.
In the spirit of worse is better, I'll note that using --output= stores
all the possible values in a single bit mask, and it's easy to define
the defaults for *all* possible outputs in one variable, and it's easy
to check *all* possible combinations with bit masks. Not so with
independent parameters. Again, matter of taste how much you appreciate
implementation simplicity. With notmuch show, I think that guideline
would have made the interface better too. YMMV.
As to notmuch address --output=address, it fulfills all the feature
needs that popped up in this thread. If there's a strong desired to
change the interface, we'll need patches as this one's already merged.
BR,
Jani.
next prev parent reply other threads:[~2017-12-20 11:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-02 18:44 [PATCH] cli: add support for only printing the addresses in notmuch address Jani Nikula
2017-12-15 12:01 ` David Bremner
2017-12-19 21:23 ` Jameson Graef Rollins
2017-12-20 1:12 ` Daniel Kahn Gillmor
2017-12-20 1:25 ` Jameson Graef Rollins
2017-12-20 7:02 ` Jani Nikula
2017-12-20 7:16 ` Jameson Graef Rollins
2017-12-20 11:15 ` Jani Nikula [this message]
2017-12-20 16:41 ` Jameson Graef Rollins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y3lxtzut.fsf@nikula.org \
--to=jani@nikula.org \
--cc=dkg@fifthhorseman.net \
--cc=jrollins@finestructure.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).