From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by arlo.cworth.org (Postfix) with ESMTP id 4F2D06DE10D3 for ; Mon, 27 May 2019 03:24:41 -0700 (PDT) X-Virus-Scanned: Debian amavisd-new at cworth.org X-Spam-Flag: NO X-Spam-Score: -0.042 X-Spam-Level: X-Spam-Status: No, score=-0.042 tagged_above=-999 required=5 tests=[AWL=-0.041, SPF_PASS=-0.001] autolearn=disabled Received: from arlo.cworth.org ([127.0.0.1]) by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H1bwPJdt2GoR for ; Mon, 27 May 2019 03:24:40 -0700 (PDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by arlo.cworth.org (Postfix) with ESMTPS id 8414D6DE0FE1 for ; Mon, 27 May 2019 03:24:40 -0700 (PDT) Received: from remotemail by fethera.tethera.net with local (Exim 4.89) (envelope-from ) id 1hVCo3-0008Pp-HJ; Mon, 27 May 2019 06:24:39 -0400 Received: (nullmailer pid 7335 invoked by uid 1000); Mon, 27 May 2019 10:24:41 -0000 From: David Bremner To: Daniel Kahn Gillmor , Notmuch Mail Subject: Re: [PATCH v2 10/17] indexing: record protected subject when indexing cleartext In-Reply-To: <20190526221610.2833-11-dkg@fifthhorseman.net> References: <20190526221610.2833-1-dkg@fifthhorseman.net> <20190526221610.2833-11-dkg@fifthhorseman.net> Date: Mon, 27 May 2019 07:24:41 -0300 Message-ID: <87y32sjity.fsf@tethera.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 27 May 2019 10:24:41 -0000 Daniel Kahn Gillmor writes: > + status = _notmuch_message_crypto_potential_payload (msg_crypto, clear, GMIME_OBJECT (encrypted_data), GMIME_MULTIPART_ENCRYPTED_CONTENT); > + _index_mime_part (message, indexopts, clear, msg_crypto); > g_object_unref (clear); If you're going to ignore the return value here (not sure if that's a good idea?) please explicitly cast to void rather than putting in status to ignore.