From: "Rollins, Jameson" <jrollins@caltech.edu>
To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,
Notmuch Mail <notmuch@notmuchmail.org>
Subject: Re: [PATCH 4/4] cli/show: show repaired form of "Mixed Up" mangled messages
Date: Thu, 30 May 2019 17:06:34 +0000 [thread overview]
Message-ID: <87y32nyiqv.fsf@caltech.edu> (raw)
In-Reply-To: <87sgsvj3du.fsf@fifthhorseman.net>
On Thu, May 30 2019, Daniel Kahn Gillmor <dkg@fifthhorseman.net> wrote:
> Yes, it does fix notmuch reply as well. Do you think that we should
> augment the test suite to include 'notmuch reply' too?
I mean, more tests don't hurt, but I don't see it as critical. I think
it could be as simple as (please verify):
test_begin_subtest "reply 'Mixed-Up' mangled PGP/MIME message"
output=$(notmuch reply --format=json --decrypt id:mixed-up@mangling.notmuchmail.org)
test_json_nodes <<<"$output" \
'body:["original"]["body"][0]["content"][1]["content"]="The password is \"abcd1234!\", please do not tell anyone.\n"'
next prev parent reply other threads:[~2019-05-30 17:06 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-28 22:54 Safe and useful handling of "Mixed Up" mangled messages Daniel Kahn Gillmor
2019-05-28 22:54 ` [PATCH 1/4] test: add test for "Mixed-Up Mime" message mangling Daniel Kahn Gillmor
2019-05-28 22:54 ` [PATCH 2/4] util/crypto: identify and repair "Mixed Up" mangled messages Daniel Kahn Gillmor
2019-05-30 2:18 ` Rollins, Jameson
2019-05-30 16:46 ` Daniel Kahn Gillmor
2019-05-30 17:01 ` Rollins, Jameson
2019-05-28 22:54 ` [PATCH 3/4] index: repair "Mixed Up" messages before indexing Daniel Kahn Gillmor
2019-05-28 22:54 ` [PATCH 4/4] cli/show: show repaired form of "Mixed Up" mangled messages Daniel Kahn Gillmor
2019-05-30 2:08 ` Rollins, Jameson
2019-05-30 2:09 ` Rollins, Jameson
2019-05-30 16:47 ` Daniel Kahn Gillmor
2019-05-30 17:06 ` Rollins, Jameson [this message]
2019-05-28 22:58 ` Safe and useful handling " Daniel Kahn Gillmor
2019-05-29 19:37 ` Daniel Kahn Gillmor
2019-05-30 2:21 ` Rollins, Jameson
2019-05-30 17:30 ` Daniel Kahn Gillmor
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y32nyiqv.fsf@caltech.edu \
--to=jrollins@caltech.edu \
--cc=dkg@fifthhorseman.net \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).