* Bug: Attempt to install notmuch-emacs.info during --without-emacs build @ 2019-06-09 16:06 Ralph Seichter 2019-06-09 17:47 ` David Bremner 0 siblings, 1 reply; 6+ messages in thread From: Ralph Seichter @ 2019-06-09 16:06 UTC (permalink / raw) To: notmuch MacPorts CI builds report the following [1]: DEBUG: system: cd "/opt/local/var/macports/build/_Users_vsts_agent_2.152.1_work_1_s_mail_notmuch/notmuch/work/notmuch-0.29" && ./configure --prefix=/opt/local --with-docs --without-emacs --without-ruby [...] Checking if emacs (>= 24) is available... No (so will not byte-compile emacs code) [...] /opt/local/var/macports/build/_Users_vsts_agent_2.152.1_work_1_s_mail_notmuch/notmuch/work/notmuch-0.29/doc/index.rst:7: WARNING: toctree contains reference to excluded document 'notmuch-emacs' WARNING: "texinfo_documents" config value references unknown document notmuch-emacs [...] install -m0644 doc/_build/texinfo/notmuch-address.info doc/_build/texinfo/notmuch-compact.info doc/_build/texinfo/notmuch-config.info doc/_build/texinfo/notmuch-count.info doc/_build/texinfo/notmuch-dump.info doc/_build/texinfo/notmuch-emacs-mua.info doc/_build/texinfo/notmuch-insert.info doc/_build/texinfo/notmuch-new.info doc/_build/texinfo/notmuch-reindex.info doc/_build/texinfo/notmuch-reply.info doc/_build/texinfo/notmuch-restore.info doc/_build/texinfo/notmuch-search.info doc/_build/texinfo/notmuch-show.info doc/_build/texinfo/notmuch-tag.info doc/_build/texinfo/notmuch.info doc/_build/texinfo/notmuch-hooks.info doc/_build/texinfo/notmuch-properties.info doc/_build/texinfo/notmuch-search-terms.info doc/_build/texinfo/notmuch-emacs.info /opt/local/var/macports/build/_Users_vsts_agent_2.152.1_work_1_s_mail_notmuch/notmuch/work/destroot/opt/local/share/info install: doc/_build/texinfo/notmuch-emacs.info: No such file or directory make: *** [install-info] Error 71 Why is the build trying to install texinfo/notmuch-emacs.info even though --without-emacs was specified during configuration and Emacs was not found during the sanity checks? [1] Full build log available at https://paste.z0k.xyz/8352cabdee6f.txt -Ralph ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug: Attempt to install notmuch-emacs.info during --without-emacs build 2019-06-09 16:06 Bug: Attempt to install notmuch-emacs.info during --without-emacs build Ralph Seichter @ 2019-06-09 17:47 ` David Bremner 2019-06-09 19:40 ` Ralph Seichter 0 siblings, 1 reply; 6+ messages in thread From: David Bremner @ 2019-06-09 17:47 UTC (permalink / raw) To: Ralph Seichter, notmuch Ralph Seichter <abbot@monksofcool.net> writes: > > Why is the build trying to install texinfo/notmuch-emacs.info even > though --without-emacs was specified during configuration and Emacs was > not found during the sanity checks? Agreed, that looks like a bug. Apprently the combination of having makeinfo but not emacs is not well tested. The following seems to fix the problem, but I haven't tested it extensively. diff --git a/doc/Makefile.local b/doc/Makefile.local index 719172fe..55ff4a64 100644 --- a/doc/Makefile.local +++ b/doc/Makefile.local @@ -28,7 +28,10 @@ MAN_GZIP_FILES := $(addsuffix .gz,${MAN_ROFF_FILES}) MAN1_TEXI := $(patsubst $(srcdir)/doc/man1/%.rst,$(DOCBUILDDIR)/texinfo/%.texi,$(MAN1_RST)) MAN5_TEXI := $(patsubst $(srcdir)/doc/man5/%.rst,$(DOCBUILDDIR)/texinfo/%.texi,$(MAN5_RST)) MAN7_TEXI := $(patsubst $(srcdir)/doc/man7/%.rst,$(DOCBUILDDIR)/texinfo/%.texi,$(MAN7_RST)) -INFO_TEXI_FILES := $(MAN1_TEXI) $(MAN5_TEXI) $(MAN7_TEXI) $(DOCBUILDDIR)/texinfo/notmuch-emacs.texi +INFO_TEXI_FILES := $(MAN1_TEXI) $(MAN5_TEXI) $(MAN7_TEXI) +ifeq ($(WITH_EMACS),1) + $(INFO_TEXI_FILES):= $(INFO_TEXI_FILES) $(DOCBUILDDIR)/texinfo/notmuch-emacs.texi +endif INFO_INFO_FILES := $(INFO_TEXI_FILES:.texi=.info) ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: Bug: Attempt to install notmuch-emacs.info during --without-emacs build 2019-06-09 17:47 ` David Bremner @ 2019-06-09 19:40 ` Ralph Seichter 2019-06-09 21:47 ` David Bremner 0 siblings, 1 reply; 6+ messages in thread From: Ralph Seichter @ 2019-06-09 19:40 UTC (permalink / raw) To: David Bremner, notmuch * David Bremner: > The following seems to fix the problem, but I haven't tested it > extensively. As shown in https://monksofcool.net/tmp/6bmjUFL.log , your suggestion results in notmuch-emacs.info being generated but unfortunately not installed when Notmuch is built --with-emacs. Obviously that's better than a build failure for --without-emacs, but it is not quite ideal either. ;-) -Ralph ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug: Attempt to install notmuch-emacs.info during --without-emacs build 2019-06-09 19:40 ` Ralph Seichter @ 2019-06-09 21:47 ` David Bremner 2019-06-09 23:16 ` Ralph Seichter 0 siblings, 1 reply; 6+ messages in thread From: David Bremner @ 2019-06-09 21:47 UTC (permalink / raw) To: Ralph Seichter, notmuch Ralph Seichter <abbot@monksofcool.net> writes: > * David Bremner: > >> The following seems to fix the problem, but I haven't tested it >> extensively. > > As shown in https://monksofcool.net/tmp/6bmjUFL.log , your suggestion > results in notmuch-emacs.info being generated but unfortunately not > installed when Notmuch is built --with-emacs. Obviously that's better > than a build failure for --without-emacs, but it is not quite ideal > either. ;-) > Attempt #2; we need to delay expansion of INFO_TEXI_FILES until WITH_EMACS is defined. diff --git a/doc/Makefile.local b/doc/Makefile.local index 719172fe..5b99dd02 100644 --- a/doc/Makefile.local +++ b/doc/Makefile.local @@ -28,7 +28,9 @@ MAN_GZIP_FILES := $(addsuffix .gz,${MAN_ROFF_FILES}) MAN1_TEXI := $(patsubst $(srcdir)/doc/man1/%.rst,$(DOCBUILDDIR)/texinfo/%.texi,$(MAN1_RST)) MAN5_TEXI := $(patsubst $(srcdir)/doc/man5/%.rst,$(DOCBUILDDIR)/texinfo/%.texi,$(MAN5_RST)) MAN7_TEXI := $(patsubst $(srcdir)/doc/man7/%.rst,$(DOCBUILDDIR)/texinfo/%.texi,$(MAN7_RST)) -INFO_TEXI_FILES := $(MAN1_TEXI) $(MAN5_TEXI) $(MAN7_TEXI) $(DOCBUILDDIR)/texinfo/notmuch-emacs.texi +INFO_TEXI_FILES = $(MAN1_TEXI) $(MAN5_TEXI) $(MAN7_TEXI) \ + $(if $(filter 1,$(WITH_EMACS)), $(DOCBUILDDIR)/texinfo/notmuch-emacs.texi,) + INFO_INFO_FILES := $(INFO_TEXI_FILES:.texi=.info) .PHONY: sphinx-html sphinx-texinfo sphinx-info ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: Bug: Attempt to install notmuch-emacs.info during --without-emacs build 2019-06-09 21:47 ` David Bremner @ 2019-06-09 23:16 ` Ralph Seichter 2019-06-10 1:08 ` Ralph Seichter 0 siblings, 1 reply; 6+ messages in thread From: Ralph Seichter @ 2019-06-09 23:16 UTC (permalink / raw) To: David Bremner, notmuch * David Bremner: > Attempt #2; we need to delay expansion of INFO_TEXI_FILES until > WITH_EMACS is defined. Works nicely for my local builds. Now I need to wait for the CI builds to run. -Ralph ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: Bug: Attempt to install notmuch-emacs.info during --without-emacs build 2019-06-09 23:16 ` Ralph Seichter @ 2019-06-10 1:08 ` Ralph Seichter 0 siblings, 0 replies; 6+ messages in thread From: Ralph Seichter @ 2019-06-10 1:08 UTC (permalink / raw) To: David Bremner, notmuch MacPorts CI builds were successful as well. Thank you for the prompt fix, David. -Ralph ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2019-06-10 1:08 UTC | newest] Thread overview: 6+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2019-06-09 16:06 Bug: Attempt to install notmuch-emacs.info during --without-emacs build Ralph Seichter 2019-06-09 17:47 ` David Bremner 2019-06-09 19:40 ` Ralph Seichter 2019-06-09 21:47 ` David Bremner 2019-06-09 23:16 ` Ralph Seichter 2019-06-10 1:08 ` Ralph Seichter
Code repositories for project(s) associated with this public inbox https://yhetil.org/notmuch.git/ This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).