unofficial mirror of notmuch@notmuchmail.org
 help / color / Atom feed
* [PATCH] configure: check existence of python3 setuptools and dev package
@ 2020-06-01  5:31 Tomi Ollila
  2020-06-01 11:22 ` David Bremner
  0 siblings, 1 reply; 2+ messages in thread
From: Tomi Ollila @ 2020-06-01  5:31 UTC (permalink / raw)
  To: notmuch; +Cc: tomi.ollila

The notmuch2 CFFI-based Python interface is not buildable unless
python3 dev package and python3 setuptools are installed.

Check that these exist in configure (and disable notmuch2 bindings
build if not) so that build of these bindings don't fail when make(1)
is executed.
---
 configure | 16 +++++++++-------
 1 file changed, 9 insertions(+), 7 deletions(-)

diff --git a/configure b/configure
index 32a836bb..e4c738e5 100755
--- a/configure
+++ b/configure
@@ -711,12 +711,14 @@ if [ $have_python -eq 0 ]; then
     errors=$((errors + 1))
 fi
 
-have_python3=0
+have_python3_dev=0
 if [ $have_python -eq 1 ]; then
-    printf "Checking for python3..."
-    if "$python" -c 'import sys; assert sys.version_info >= (3,0)' > /dev/null 2>&1; then
+    printf "Checking for python3 dev..."
+    if "$python" -c 'import os, sys, sysconfig;
+assert sys.version_info >= (3,0)
+assert os.path.isfile(sysconfig.get_config_h_filename())' >/dev/null 2>&1; then
         printf "Yes.\n"
-        have_python3=1
+        have_python3_dev=1
     else
         printf "No.\n"
     fi
@@ -724,9 +726,9 @@ fi
 
 have_python3_cffi=0
 have_python3_pytest=0
-if [ $have_python3 -eq 1 ]; then
-    printf "Checking for python3 cffi... "
-    if "$python" -c 'import cffi' >/dev/null 2>&1; then
+if [ $have_python3_dev -eq 1 ]; then
+    printf "Checking for python3 cffi and setuptools... "
+    if "$python" -c 'import cffi; import setuptools' >/dev/null 2>&1; then
         printf "Yes.\n"
         have_python3_cffi=1
     else
-- 
2.25.1

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] configure: check existence of python3 setuptools and dev package
  2020-06-01  5:31 [PATCH] configure: check existence of python3 setuptools and dev package Tomi Ollila
@ 2020-06-01 11:22 ` David Bremner
  0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2020-06-01 11:22 UTC (permalink / raw)
  To: Tomi Ollila, notmuch; +Cc: tomi.ollila

Tomi Ollila <tomi.ollila@iki.fi> writes:

> The notmuch2 CFFI-based Python interface is not buildable unless
> python3 dev package and python3 setuptools are installed.
>
> Check that these exist in configure (and disable notmuch2 bindings
> build if not) so that build of these bindings don't fail when make(1)
> is executed.

I pushed this.

I did notice that the existing python related checks are not as friendly
as some other parts of the configure script in terms of telling the user
what the consequences of a "No" answer to the check is.

d

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-01  5:31 [PATCH] configure: check existence of python3 setuptools and dev package Tomi Ollila
2020-06-01 11:22 ` David Bremner

unofficial mirror of notmuch@notmuchmail.org

Archives are clonable:
	git clone --mirror https://yhetil.org/notmuch/0 notmuch/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 notmuch notmuch/ https://yhetil.org/notmuch \
		notmuch@notmuchmail.org
	public-inbox-index notmuch

Example config snippet for mirrors

Newsgroups are available over NNTP:
	nntp://news.yhetil.org/yhetil.mail.notmuch.general
	nntp://news.gmane.io/gmane.mail.notmuch.general


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git