* [PATCH v2] emacs: When completing tags, offer each tag once
@ 2021-02-03 9:10 David Edmondson
2021-02-05 14:17 ` David Bremner
0 siblings, 1 reply; 2+ messages in thread
From: David Edmondson @ 2021-02-03 9:10 UTC (permalink / raw)
To: notmuch; +Cc: David Edmondson
When prompting for one or more tags to add or remove to/from one or
more threads, ensure that the set of tags offered for completion
contains no duplicates.
Some completion packages (e.g. selectrum) will include every member of
the offered list, resulting in the same tag being indicated as a
possibility several times.
---
Use `delete-dups' rather than hand-coding similar.
emacs/notmuch.el | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/emacs/notmuch.el b/emacs/notmuch.el
index 26efcccd..6d37c623 100644
--- a/emacs/notmuch.el
+++ b/emacs/notmuch.el
@@ -577,7 +577,7 @@ thread."
(notmuch-search-foreach-result beg end
(lambda (pos)
(setq output (append output (notmuch-search-get-tags pos)))))
- output))
+ (delete-dups output)))
(defun notmuch-search-interactive-tag-changes (&optional initial-input)
"Prompt for tag changes for the current thread or region.
--
2.30.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH v2] emacs: When completing tags, offer each tag once
2021-02-03 9:10 [PATCH v2] emacs: When completing tags, offer each tag once David Edmondson
@ 2021-02-05 14:17 ` David Bremner
0 siblings, 0 replies; 2+ messages in thread
From: David Bremner @ 2021-02-05 14:17 UTC (permalink / raw)
To: David Edmondson, notmuch; +Cc: David Edmondson
David Edmondson <dme@dme.org> writes:
> When prompting for one or more tags to add or remove to/from one or
> more threads, ensure that the set of tags offered for completion
> contains no duplicates.
applied to master
d
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2021-02-05 14:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-02-03 9:10 [PATCH v2] emacs: When completing tags, offer each tag once David Edmondson
2021-02-05 14:17 ` David Bremner
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).