From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id 6AVBA04LoWBgFQEAgWs5BA (envelope-from ) for ; Sun, 16 May 2021 14:08:46 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id yEWAOk0LoWB3cAAAB5/wlQ (envelope-from ) for ; Sun, 16 May 2021 12:08:45 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9F33413B8C for ; Sun, 16 May 2021 14:08:45 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id DCC39271E8; Sun, 16 May 2021 08:08:39 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 9E68B2717B for ; Sun, 16 May 2021 08:08:37 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 7EEDB60018; Sun, 16 May 2021 08:08:37 -0400 (EDT) Received: (nullmailer pid 3220990 invoked by uid 1000); Sun, 16 May 2021 12:08:36 -0000 From: David Bremner To: Felipe Contreras , notmuch@notmuchmail.org Subject: Re: [PATCH v2 2/6] test: more style fixes In-Reply-To: <20210515204744.965206-3-felipe.contreras@gmail.com> References: <20210515204744.965206-1-felipe.contreras@gmail.com> <20210515204744.965206-3-felipe.contreras@gmail.com> Date: Sun, 16 May 2021 09:08:36 -0300 Message-ID: <87y2cezxrv.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: YIK3J3TGUQGD7QX7Y6HRV6OCAHKNOBRH X-Message-ID-Hash: YIK3J3TGUQGD7QX7Y6HRV6OCAHKNOBRH X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1621166925; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=PtL2yxUI91WjE743CEwhFqtEou0wVUJU7VIW7ktuZTk=; b=W0YaNhM7E9VoRe2GjcdMMKd8woDfAdXd195+OXkG2S2W9v+Z0nvHbH2NYjQE5fb4o04eG8 Ax1qUpJViHh99OzRx0LTvGBzKkfCRMN6x02yP5MRKk59W5CpgyxuayKntH6ntro7/WkpwK k/cfYfK7Ol3elvqf4OqHMnQADABBetRlmYLM36XvIN/TZ7cpBZisGCK7CRy3ZOzHA8eF0x TyByghIVHkuTqpO8P5UHeCQx4Mf1itmECjRNYIt8ADbLpjs4VhBOu99AWjkJgEZE0i60gW ECoAACX19CLL1f5NCXX+RXRRUaIbz4EmseE6vEufFWZ1qGK7J58+QjSKWYpmRA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1621166925; a=rsa-sha256; cv=none; b=LzJPEMJzljznSvQG63kbhsRB4D6GV76LUPaXZcNk0KqGt+aZXNJMdul6QWD6aTYd98BNIP ewtu2G83R3SS/+61BmmilujmAtRDF+sg2LENYeDau1vks9tJxwVNM6rYNpBV9CiuYCsCg6 nIWTpPD9KbdJzfSP2J2VegmvI5xIl+OsOrMKD5tUXa4vrttJso5IxN4dkCUlCqTHXeW0/K ooJgLt0Si8JHwnvdZFeHC88+tjVeEostXOZa7mid00Ir9qczYWHy/x/KbkxmLaGor6DKDo uoUlZUXD+MUtBmmpwFLDIHr1FFHkl8VRBwzpjR9atd94m7wnJwLXyu9SjWMOmQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.55 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 9F33413B8C X-Spam-Score: -0.55 X-Migadu-Scanner: scn0.migadu.com X-TUID: kSMYerW1ylZx Felipe Contreras writes: > In order to fit the git coding style. > > Signed-off-by: Felipe Contreras I personally prefer this style, but I have to point out that the C and C++ code in the code base (including the Ruby bindings) use the "brace-on-the-next-line" style. Should we strive for consistency with the C code, or is there some overriding concern here? Tomi mentioned compactness; is that more important for shell scripts? Whatever we decide, I guess it should be documented in test/README. For the record, I don't think restyling the rest of the codebase to match is a good option.