From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id eGpVGMxHLmFtPwEAgWs5BA (envelope-from ) for ; Tue, 31 Aug 2021 17:16:28 +0200 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id 6CPWE8xHLmEUYAAA1q6Kng (envelope-from ) for ; Tue, 31 Aug 2021 15:16:28 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 1A7A822A51 for ; Tue, 31 Aug 2021 17:16:28 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 2408620678; Tue, 31 Aug 2021 11:16:24 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 3614520645 for ; Tue, 31 Aug 2021 11:16:22 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id DDEE55FD5C; Tue, 31 Aug 2021 11:16:21 -0400 (EDT) Received: (nullmailer pid 475042 invoked by uid 1000); Tue, 31 Aug 2021 15:15:52 -0000 From: David Bremner To: inwit , notmuch@notmuchmail.org Subject: Re: [PATCH] emacs: Re-apply an old patch to fold/unfold threads in tree-view In-Reply-To: <20210831110111.3148499-1-inwit@sindominio.net> References: <20210831110111.3148499-1-inwit@sindominio.net> Date: Tue, 31 Aug 2021 08:15:52 -0700 Message-ID: <87y28h4pcn.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: GKX2DR7P7U34ZSYXYXM2W6V7TUORX7A2 X-Message-ID-Hash: GKX2DR7P7U34ZSYXYXM2W6V7TUORX7A2 X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header CC: Julien Masson X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1630422988; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=DUYCexDqPdT2OjPUaXyY7GGkpvmZnrQ8wQpCvrtd9lo=; b=IBVibWbxUwuan+P/Q869NU0NowKJQtYKscYPBLNF6Z0pAfZIVEN9e1ddDbTnhcqcN6i+Ny wlxKcuDJppyuUahlfFdSZDyLBQnxKsoFHQDMusojz//4/qQfTOgGXfGpy1GQVJSSkpDeuf aVFAxHsbTrAIpGGhsiztaYT2AH26d7NZL0HSNgKRVA0uAgil1x0SCA3zOvTIo73fOmCVWf d9dxVKFPh1SaMRGzBTmvSoo3LtWUb4HGSfSykO1d5LmIYjz8RtJQ5EhoXKLvNyKYUWM+1F MF0v4PpR82Ncdt6SJmZM7Dh/qnwhY4uhJeewQ6XzhjWnBn+C+e79qlMMtwbqvQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1630422988; a=rsa-sha256; cv=none; b=HmtdzMI4Q7bSkGFGAQl+4jZ1Dy5B0VUeBgEtVl3/4S9InCyzp1Q95UnIrWNWSZWIhPPmXd VPoorPnDg+gCyjmU2maHF43EMFmRHXNV4UoWmU6kbNQ7Q80c3YAoCw4s76TEGdnTd5mPiY yf3o2fPJz5JPEKrl8kDNh/3XmBhZGnQu+lgTC23zg8pelOmciG1c0RyEPJqGyImf1/Wc8d E3lZp5k6Kqzyn5WK0WHIpo11v96o7VH8yOnlY9aLRqjvdMuyoI4A4EoqZIm6LK/m6fD3Db HFzAvup1ZphorNYrt9DpX10weVA8Th29Wjq5PQvZzAHT0wb0sCzLQUUCOrpj+w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.02 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 1A7A822A51 X-Spam-Score: -2.02 X-Migadu-Scanner: scn0.migadu.com X-TUID: 1xv7RT94FbYY inwit writes: Thanks for reviving this. Eventually you'll want to add a proper commit message and address some of the previous review. But first, I think I found a bug, see below > --- > emacs/notmuch-tree.el | 92 +++++++++++++++++++++++++++++++++++++++++++ > 1 file changed, 92 insertions(+) > > diff --git a/emacs/notmuch-tree.el b/emacs/notmuch-tree.el > index b48a132d..24b4105b 100644 > --- a/emacs/notmuch-tree.el > +++ b/emacs/notmuch-tree.el > @@ -131,6 +131,11 @@ Note that the author string should not contain whitespace > notmuch-unthreaded-result-format > notmuch-tree-result-format)) > > +(defcustom notmuch-tree-overlay-string " [...]" > + "String displayed at the beginning of the overlay" > + :type 'string > + :group 'notmuch-tree) There seems to be problems introducing this overlay. I either don't see it, or it is added to the wrong buffer. To reproduce, go to *scratch*, write (notmuch-tree "thread:{id:20210831110111.3148499-1-inwit@sindominio.net}") at the end, of the line, C-x C-e in the resulting tree-view, type 't' to toggle thread hiding. For me the tree-view goes away and [...] is applied to the *scratch* buffer. I suspect this bug was in the original patch. About the binding, have a look at devel/emacs-key-bindings.org to help choose a key; a final version of the patch should update that file and doc/notmuch-emacs.rst