From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id YO20Fq3cZmEEKwEAgWs5BA (envelope-from ) for ; Wed, 13 Oct 2021 15:18:37 +0200 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id +JFoEq3cZmGiMQAA1q6Kng (envelope-from ) for ; Wed, 13 Oct 2021 13:18:37 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id A3922C479 for ; Wed, 13 Oct 2021 15:18:36 +0200 (CEST) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id C22BE2C185; Wed, 13 Oct 2021 09:18:30 -0400 (EDT) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id E5CE42C181 for ; Wed, 13 Oct 2021 09:18:27 -0400 (EDT) Received: by fethera.tethera.net (Postfix, from userid 1001) id 69E185FBE5; Wed, 13 Oct 2021 09:18:27 -0400 (EDT) Received: (nullmailer pid 2111343 invoked by uid 1000); Wed, 13 Oct 2021 13:18:26 -0000 From: David Bremner To: Jani Nikula , notmuch@notmuchmail.org Cc: jani@nikula.org Subject: Re: [RFC 2/5] lib: remove enum names from typedefs In-Reply-To: <20211012185127.198348-3-jani@nikula.org> References: <20211012185127.198348-1-jani@nikula.org> <20211012185127.198348-3-jani@nikula.org> Date: Wed, 13 Oct 2021 10:18:26 -0300 Message-ID: <87y26xkqql.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: ZJGLAQ6PTJNA5E7D5NJZNOEVOQBQZLJZ X-Message-ID-Hash: ZJGLAQ6PTJNA5E7D5NJZNOEVOQBQZLJZ X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; suspicious-header X-Mailman-Version: 3.2.1 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1634131117; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=8ddOdsTWf18VH6hru7+IiGJHp0T9tPMGXjXvlmv93F0=; b=GJmpn2nlxNPmMoro4YoEv23qcMBsvjx9e3h95893sMhI7DMe/0nrH2hJanuqV7av9Dxdj7 Bghj3e9KzqISiaEv/AEW2KUGeHWje2YcRbNadNNuO5ulNFxESc+cZfovSqPvW5QePJH22E 25bwshZkJf1IUfOeZCgEir0YKUEDCFjVxdMIybMREGBHzsW109tN1sYZ4qvd61cbnySwI7 2qsNU9wvO1uGYaS0ngOxebtBxLWn7/7Wz8Hf2p+H5efoBOo3KQqRnJ7mEwQJAxDBlCMVoo UVco8yqlawu7cbQzRYJ9L3i+Qsq4Qa1IxFaromXzzottKElCzTohhJXyqAVTzQ== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1634131117; a=rsa-sha256; cv=none; b=Fc7D+dWsYliB+WQXZVb46HX882vK1jUac63iNwqnjknRHxIapbLOdZfdFiFPcpmaoc3ycK DXf1G/6k8+lFICM7DhLEmihd+uNMF56KL6ci1xQR+n0SCJq/x3Ocnf0DT7I1w088gjmTvR wxEqeAWuIHVBHpo/Lm5q8Jh4WksZp7P1dlKRTBvk3Ko2treeG2wnqb16Wq5tiIF+jQbYXL E7/512G0tljxva/mKVBuSGeYJBa9wmW63nVmxYHhLll2rf+a+ePtH2M5Z8HEc3YLrLNAHE xZFzX3CA//tzQMmzBBjfTyZJ1IGWU67VnYAsv0w70FYGKb6QAoIyGdc47d2/lw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.04 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: A3922C479 X-Spam-Score: -2.04 X-Migadu-Scanner: scn0.migadu.com X-TUID: wIVIr9Rzqmno Jani Nikula writes: > Given the named enum typedef: > > typedef enum _name_t { ... } name_t; > > Hawkmoth uses _name_t as the name for documentation. Typedef the > anonymous enum: > > typedef enum { ... } name_t; > > instead to use name_t. We don't really need the enum names for > anything, and not all of the enum typedefs have them anyway. > --- I guess that change would be fine independent of the rest?