From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id uP/hLjBGu2ENAAEAgWs5BA (envelope-from ) for ; Thu, 16 Dec 2021 14:59:12 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id UBqsKjBGu2EQcAAA1q6Kng (envelope-from ) for ; Thu, 16 Dec 2021 13:59:12 +0000 Received: from mail.notmuchmail.org (nmbug.tethera.net [IPv6:2607:5300:201:3100::1657]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 7B57C11E2C for ; Thu, 16 Dec 2021 14:59:12 +0100 (CET) Received: from nmbug.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id E4CFD297C0; Thu, 16 Dec 2021 08:59:03 -0500 (EST) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 7C6DF297BE for ; Thu, 16 Dec 2021 08:59:00 -0500 (EST) Received: by fethera.tethera.net (Postfix, from userid 1001) id DAB1D5FC42; Thu, 16 Dec 2021 08:58:59 -0500 (EST) Received: (nullmailer pid 3171507 invoked by uid 1000); Thu, 16 Dec 2021 13:58:58 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: Re: [PATCH] WIP/emacs: replace use of indent-rigidly in notmuch-show In-Reply-To: <20211214121726.2631714-1-david@tethera.net> References: <20211214121726.2631714-1-david@tethera.net> Date: Thu, 16 Dec 2021 09:58:58 -0400 Message-ID: <87y24kk5wd.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: F2VBOWUXTPLCKATYPRPQ4OYWOBAIYZTA X-Message-ID-Hash: F2VBOWUXTPLCKATYPRPQ4OYWOBAIYZTA X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: FR ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1639663152; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=IlzIVMPWfR9XEoxRH4xqpTdc6LPDypUpNM2ybvg2f4A=; b=A0MRX7S/TcghEdD9oadD+TSSKuO+Xs/okptiBBmn5xw5I/w036vvkDMMS/Tj5V9dDNqqZ8 bx9X3QcNtkReyb9OI5pzo3nngmK3kKJBk+ILv261I74qYS+kVM9pr5fxqDN8Quc0QkmHrx EpmezlWx4CY7TVfWcPoSp+w2vFZf+wCj0JKMBT2cePeDKMcFegHCCdKZl7VNMU7z7pVVCX 0P1DA8HQOcjowdEnpFseJqUJDP2ca6loNRMkDevgvcs+1xldm992hNKjgUuVXrKAYrk8pX 7H+2vvia6D5BUXQBBbcK+RfSOniFT+ACbwvZR8r5ER148TqsW0xBrzxPt5R8Lw== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1639663152; a=rsa-sha256; cv=none; b=WtzM5HqsJjYSR583KOCVXB7pP8Qheqwc0ZUY0uoj6v+ipCxd6bN80MzCwl9Ai4iGQ2tuuF FFfUsnHItUDtuygnoBwmYvhLsIiMue1Fez2mLGK6TzA6tG+3x+zakQH+GGLP6asLLC/qhm I9jQZgfm0L8FL2YCkYc6NkdSIsFh3Z4ksk+j0duaS84Vu2Y5uliJK3ld95hmJSWqxvED+5 NEHxuLiLibwzH4bLCXAaRflgmh3HM/JiSg2f+JifiJ0e9UV/FQ83ug2Q7jxNpbPutE3DMB 4fwK7fLBxW1Bdw0pHvXRVWkj0VjFCjbw+rpFeRUvJe8ftww6WfnN4PGmwGXoZA== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -0.49 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2607:5300:201:3100::1657 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: 7B57C11E2C X-Spam-Score: -0.49 X-Migadu-Scanner: scn0.migadu.com X-TUID: cCtcF+FsaYtZ David Bremner writes: > Several people have observed that the display of patches in > notmuch-emacs is less than ideal because context lines do not line up > properly with changed lines. The underlying cause is that > indent-rigidly adds space in different places for those lines. In this > commit, indent-rigidly is replaced with a more simple-minded function > that always adds spaces to the beginning of the line. > --- > > This is not really well tested, and somewhat copy-pasta-ed together > code. Looking at this mail, I see the indentation of the call sites is > not great either. There is at least one bug still. If you open a thread with a matched message that is not the first message, the cursor is positioned after the matched message, sometimes causing the wanted message to scroll off the top of the screen.