unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: notmuch@notmuchmail.org
Subject: Re: [PATCH] WIP/emacs: replace use of indent-rigidly in notmuch-show
Date: Thu, 16 Dec 2021 09:58:58 -0400	[thread overview]
Message-ID: <87y24kk5wd.fsf@tethera.net> (raw)
In-Reply-To: <20211214121726.2631714-1-david@tethera.net>

David Bremner <david@tethera.net> writes:

> Several people have observed that the display of patches in
> notmuch-emacs is less than ideal because context lines do not line up
> properly with changed lines. The underlying cause is that
> indent-rigidly adds space in different places for those lines. In this
> commit, indent-rigidly is replaced with a more simple-minded function
> that always adds spaces to the beginning of the line.
> ---
>
> This is not really well tested, and somewhat copy-pasta-ed together
> code. Looking at this mail, I see the indentation of the call sites is
> not great either.

There is at least one bug still. If you open a thread with a matched
message that is not the first message, the cursor is positioned after
the matched message, sometimes causing the wanted message to scroll off
the top of the screen.

      reply	other threads:[~2021-12-16 13:59 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-12-14 12:17 [PATCH] WIP/emacs: replace use of indent-rigidly in notmuch-show David Bremner
2021-12-16 13:58 ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y24kk5wd.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).