From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms0.migadu.com with LMTPS id INITDuUbCGJI1wAAgWs5BA (envelope-from ) for ; Sat, 12 Feb 2022 21:43:17 +0100 Received: from aspmx1.migadu.com ([2001:41d0:2:bcc0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id GGR9C+UbCGJm4wAA9RJhRA (envelope-from ) for ; Sat, 12 Feb 2022 21:43:17 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D0ABE3A81C for ; Sat, 12 Feb 2022 21:43:16 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id D58405F704; Sat, 12 Feb 2022 20:43:14 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [IPv6:2607:5300:60:c5::1]) by mail.notmuchmail.org (Postfix) with ESMTP id 0AE295F6C3 for ; Sat, 12 Feb 2022 20:43:12 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 8394F5FBD2; Sat, 12 Feb 2022 15:43:11 -0500 (EST) Received: (nullmailer pid 2584816 invoked by uid 1000); Sat, 12 Feb 2022 20:42:58 -0000 From: David Bremner To: Michael J Gruber , notmuch@notmuchmail.org Subject: Re: [PATCH 2/4] test: due not pass T380.1 for the wrong reasons In-Reply-To: <164449061694.6325.1611477846768874524.git@grubix.eu> References: <8d483901f3cf9bee86d7359ff1d665943adcd31b.1644406756.git.git@grubix.eu> <87pmnvzo3b.fsf@tethera.net> <164449061694.6325.1611477846768874524.git@grubix.eu> Date: Sat, 12 Feb 2022 16:42:58 -0400 Message-ID: <87y22fx1d9.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: I7REI7XMJPUMBZEWWAXVPQHWJOHRBRXO X-Message-ID-Hash: I7REI7XMJPUMBZEWWAXVPQHWJOHRBRXO X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1644698597; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=NSsltN9Ss6uRyGlANTtAomN78tAmo1cyDyDhoEnRT48=; b=psLddRoTHUOZzkvPkkMxkHkGoHBsvkMe7WlRkUnkZfuPg2aKI0jwwhIzRBOog6L+7WsFlb +KZv802eT04ND2wMI/W34peFFizfMnRXapYfJ29JI0kpXReN5BhmjhafXXYUWcfwz/jXrk f59dIu68uVNXfX36BiJA1C8NW52Eofk75MeLp/vg1CVxxKTLnhrsqXronOdjqZnDjC8SoD JycF7vy+YfvvG1TkskYAL4xkGnQFwYn2qjs/OE8ZO6STI0XFDeyoiZgsgvAXL+RQ/SvVZI 4/rg+5w35cKDYotlooXDQvXAPbPv9Qt8RVBwYRGJDYsv+9hDqbtWEh4DbZz85A== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1644698597; a=rsa-sha256; cv=none; b=IX3TsqrUTWSRGa6JrzT4LJR/ZRE+E/epoF+TUqMVKjGoEKgBqtZYX0d7324lPx49zXloo+ DhE1ynepNsafzMUUa9oqz4Dk4bGF6Ls8SUiY6/boDMw/dl5bEtnT9+9KaFDLJj/EJROi0n OjO2AzlH7HRDCrCpml7q8rLKODn5JOMo9Jgcrex3Bc2yMczDxX7oC/EeupqlENp7srrEnA ZQpIXY1u+mOL36TioCRoHssfCQIvjfI/WTimJg/SJPpnmVrviES1LM3lXtCUCfGRIeh425 W24lBoBfPxuWfYvAmjB/xdzp8IffFUVtVwHMsDV53VpmbTZrdUFPNbm1cboNZw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Spam-Score: -2.85 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org X-Migadu-Queue-Id: D0ABE3A81C X-Spam-Score: -2.85 X-Migadu-Scanner: scn0.migadu.com X-TUID: LHJlqxH1YM60 Michael J Gruber writes: > When analysing this, I was confused by the way > test_require_external_prereq works and the "if" in T380 (as opposed to how > test_require_external_prereq is used in other tests). Over at git.git, > we have test setup code in functions which don't get executed if > prerequisites fail. I guess the "if" emulates that, but then the actual > tests in T380 are outside the if block and use files and variables which > are created in the if block. So, this is something to fix anyways. agreed. > Add to this the fact that the tests needing sfsexp or asan (and probably > others) do things yet differently and call "test_done" immediately, so > that no SKIP appears. And those were the only ones skipped at all here ... > I think that's probably my fault for also not really understanding the prereq system. > In the short run, initialising variables and files which are used is > still a good thing, but I would have to rewrite some commit messages. sure. > I'll wait until it's clear how to handle style, though: switch to printf > from echo whenever I touch those lines (leading to mixed use) or keeing > style and leaving the style change for another series. I think I lean to fixing the usage of echo -n incrementally (i.e. don't introduce more). It might be a bit uglier in the short term, but eventually we'll get there. It turns out that echo is _not_ builtin in bash, so this really is a portability bug. d