From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp10.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms5.migadu.com with LMTPS id CD7fDEQWq2NcHQAAbAwnHQ (envelope-from ) for ; Tue, 27 Dec 2022 16:59:00 +0100 Received: from aspmx1.migadu.com ([2001:41d0:8:6d80::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp10.migadu.com with LMTPS id GCEaDEQWq2PiLwAAG6o9tA (envelope-from ) for ; Tue, 27 Dec 2022 16:59:00 +0100 Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id D4CBE3976F for ; Tue, 27 Dec 2022 16:58:59 +0100 (CET) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id B7FF25FC12; Tue, 27 Dec 2022 15:58:57 +0000 (UTC) Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197]) by mail.notmuchmail.org (Postfix) with ESMTP id 980EE5E54A for ; Tue, 27 Dec 2022 15:58:54 +0000 (UTC) Received: by fethera.tethera.net (Postfix, from userid 1001) id 02CE45FBA9; Tue, 27 Dec 2022 10:58:53 -0500 (EST) Received: (nullmailer pid 3795865 invoked by uid 1000); Tue, 27 Dec 2022 15:58:53 -0000 From: David Bremner To: notmuch@notmuchmail.org Subject: Re: [PATCH] CLI/git: use --exclude=false when calling notmuch-search In-Reply-To: <20221016124900.662786-1-david@tethera.net> References: <20221016124900.662786-1-david@tethera.net> Date: Tue, 27 Dec 2022 11:58:53 -0400 Message-ID: <87y1qsu9c2.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: N72EIEEBPKHICET6MA5U3NG2HX4I3LXY X-Message-ID-Hash: N72EIEEBPKHICET6MA5U3NG2HX4I3LXY X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Country: DE X-Migadu-Flow: FLOW_IN ARC-Seal: i=1; s=key1; d=yhetil.org; t=1672156739; a=rsa-sha256; cv=none; b=dPxD4lYcg/WA75o72dl06Jlvdq3GmJD8yuucl90gI65rBG15YJPSU/im39L9F7gwdXrhVT BLgg3hQexPoQ1IUt+wztzjLhCwbBZM434uVQWt7q17Ks7goBeL1JgZXYNqWzO1WiIQOhs6 O4giKgb/VlpZ046a43YC5oKEbyNnZvFfY9eWGdi3RUa8CjoA6O1INgu9wJa2ttkQG2HzM9 csprsIwfY8bXjo+AnFf7OiGlH/S1NxY/aCDyDVdSuLJJyinnrJrFdA1G/Cq/07e4snYAfA ugp1f0VvqdW/TE+AIihYtO6RHbW5hLXMAVvtMPbHBFX4J2u2SRjSbrsV/Cy6dw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1672156739; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=ufhdtIHJaq2chluiIRzk0+cON1MsIzOSWEFdXomkHK8=; b=C5+dMOnHsgDroIXcGlBqmnJ15j94dVGIxfX6jnJBDgu7tgRbiNGNRoph7L7X6k3gIyM1Ct 26v+nnuiLKVtNEv7cgxffIzhiew0AxF5xfSa5oCHYazWfwbIFcUeofJz64VMQRC3naNnuM Fyd+HD1HJq7ta37+4XUC8Jg8dcWSC3FvV3k7burv7L1SdYiKimB36u493vDVuHSy+/fywO Ec0GLApenWj+F0SZVgEbvl7cw6+osiqqQ7fX346NENNwG1M8LLnDCbFnVWgoy7PcBJb21e E7uwlfDkPTlpiLGCbEkpTrif0yaBQr2QgHobXg3/K8j3yqZCv3JslK75z4jrvg== X-Spam-Score: -1.70 X-Migadu-Queue-Id: D4CBE3976F Authentication-Results: aspmx1.migadu.com; dkim=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org; dmarc=none X-Migadu-Scanner: scn0.migadu.com X-Migadu-Spam-Score: -1.70 X-TUID: FzQnUcILhXy3 David Bremner writes: > We use notmuch search in two places in notmuch-git.py: to find which > tags have a given prefix, and to see if message with given id exists > locally. In both cases we do not want the presence of exclude tags > (e.g. deleted) to change the results. > --- > notmuch-git.py | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > The effects of this bug are a bit subtle; out of 12324 messages tagged > 'deleted', without this fix I was missing 25 messages. That probably > explains why I couldn't come up with a test to demonstrate the > issue. On other hand, I think it is pretty clearly the right thing to > do, even if most people don't notice a change. applied to master. d