From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp11.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms9.migadu.com with LMTPS id gHGhA5/I2GTCgAEASxT56A (envelope-from ) for ; Sun, 13 Aug 2023 14:12:15 +0200 Received: from aspmx1.migadu.com ([2001:41d0:306:2d92::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp11.migadu.com with LMTPS id AAt+A5/I2GRiEAAA9RJhRA (envelope-from ) for ; Sun, 13 Aug 2023 14:12:15 +0200 Received: from mail.notmuchmail.org (yantan.tethera.net [IPv6:2a01:4f9:c011:7a79::1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 75C594D597 for ; Sun, 13 Aug 2023 14:12:14 +0200 (CEST) Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1691928734; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post; bh=6puvflHP3CHZ/6qL0V16C3VCn32RSukR5XW4TLXKEnM=; b=X8qyYWSZzOBcZuXGRuqX4OyRzkOGBZOebxhWCuNHMTdS8GpnxisV33zWUlJP1EAwiOOtsm lIIHEVUdm2Luq/wcUfzxsvwWInL6m2HaY6FjfwqlY5+L6D3UBujvZXUsDWL8GM5s4dEIQ4 +05iTv3UykCNkJhzrvKM+kosnduhRwRbAcv+Mcq5lBAftralbmv3kCBbdL6xbM9Pxo+JRP Z+eVakmFBeKyPTOPNBBP8crjnnfelr52CjPCZ1F2hCJDZPObsNcCYfZjhRZ3LgPq/B44TO 4NhDOvOHgKYWGJQUF8x1Xx68nLl4uN1dOVZSceBZ793mWmwlBDS4mQt7CKsKJw== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 2a01:4f9:c011:7a79::1 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org ARC-Seal: i=1; s=key1; d=yhetil.org; t=1691928734; a=rsa-sha256; cv=none; b=qK/igFXDOtCPqT4bHVrRcJBVvwSN/TMx1SSuVp7nYj81v02uU3x57DJxZ/sTZxDXdxUZWo j8wgn+Nb9fQehAH+5g+ZboWUw8GIM/i5KHKKYR48G7DuC/jKyabypYWHUzbPn+ZQxXZG4L btsqBWA64TDI8xgCrVmrSvcAtFzbBheAiYMzGpycYiRbGtLFhO9GuicHXdbZugXVV6c1wJ HpI+j2xZI8lK5f08ABCDU7hWHx2PktoqDUPVlMpGAskFB2336pIWpXJE8z/YgtB5u/Zrvr +fwl49Sa5mY0Mdx+S/REs7y+cGdJCrYOg0UGnMd7eM4IBlYxqL8HywTmAyPMrA== Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id CDF925E021; Sun, 13 Aug 2023 12:12:11 +0000 (UTC) Received: from phubs.tethera.net (phubs.tethera.net [IPv6:2607:5300:60:3a9d::1]) by mail.notmuchmail.org (Postfix) with ESMTPS id 1B35D5E01C for ; Sun, 13 Aug 2023 12:12:09 +0000 (UTC) Received: from tethera.net (fctnnbsc51w-159-2-210-253.dhcp-dynamic.fibreop.nb.bellaliant.net [159.2.210.253]) by phubs.tethera.net (Postfix) with ESMTPS id 6E10C180172; Sun, 13 Aug 2023 09:12:07 -0300 (ADT) Received: (nullmailer pid 845048 invoked by uid 1000); Sun, 13 Aug 2023 12:12:06 -0000 From: David Bremner To: Jon Fineman , notmuch@notmuchmail.org Subject: Re: Hiding hidden image In-Reply-To: <87350qlbt7.fsf@ryzen.jonjfineman.com> References: <87350qlbt7.fsf@ryzen.jonjfineman.com> Date: Sun, 13 Aug 2023 09:12:06 -0300 Message-ID: <87y1if6t0p.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: 55PJBDLTEG442MFMIVYTCQSZGYHOK4SS X-Message-ID-Hash: 55PJBDLTEG442MFMIVYTCQSZGYHOK4SS X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE X-Migadu-Spam-Score: -4.30 X-Spam-Score: -4.30 X-Migadu-Queue-Id: 75C594D597 X-Migadu-Scanner: mx2.migadu.com X-TUID: 6qvHirKocdSI Jon Fineman writes: > This occurs using either: > > notmuch version 0.37 and emacs version 29.1 on Debian trixie/sid X11/XFCE > > or > > OpenBSD OpenBSD 7.3-current (GENERIC.MP) #1327 X11/awsomewm. > > I received an email with a hidden image/png. When I click on it, the > image displays fine. However when I click on it again to hide it the > email body text following it moves up as expected, but the picture > doesn't hide (go away). So I am left with the image overlaying the > email text. When I hide it the status of the attach line does change > to (hidden). Hi Jon; Thanks for the report. I suspect this has to do with the new overlay handling code in 29.1, but I haven't managed to isolate what exactly is going on yet. I did verify that the problem does not occur with Emacs 28.2 on Debian testing. I I also noticed that it does not happen for all png image parts, but the pattern of what works and what does not is also unclear to me so far. I observed that the following function (defun hideit () (interactive) (overlay-put (car (last (overlays-at (point)))) 'invisible t)) exhibits the same behaviour as toggling the button: i.e. one works iff the other does. The fact that the overlay in question is the last one is a I think a notmuch specific hack. I don't have much to suggest, but I guess a start would be to identify some distinguishing characteristics for the messages where the part visibility fails to toggle. The problem does seem to manifest in more cases than not. d