From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id 4CRfKAA2omacgQAAqHPOHw:P1 (envelope-from ) for ; Thu, 25 Jul 2024 11:24:49 +0000 Received: from aspmx1.migadu.com ([2001:41d0:303:e224::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0.migadu.com with LMTPS id 4CRfKAA2omacgQAAqHPOHw (envelope-from ) for ; Thu, 25 Jul 2024 13:24:49 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=tethera.net header.s=2024 header.b=XgOQaQG4; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1721906688; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-owner:list-unsubscribe:list-subscribe:list-post:dkim-signature; bh=FB6KMs+iSbkk/IFzfOoYZYb/u7WgDCiIlZu22xvrXEg=; b=KgAppgY6W4DWGGlOcV9CcfwkkWGhDTVCrqQDn9140VdlMcJltXRrq0FbYFTXXTE0qFsifY LBDxwlFfPItzMzNMsrAdHYFzDQZlm+DRzyiWdkvcYc+NcGeBLgsBpMnHYaF9pMXKN2lnEU e0jPgUuWZNcOsQTjn3oV8yP9TAsohX9ZWPlfg61dfZjIZn2GOnoblMOQyNsNn/pzvaS1Ti qlwqczJWp97Ag86hanC6F5IyKORu4hoQld/axQqhWE8esXv5zdrfXcF+IrINtgIKtKyAmT lDRzo8m9FXH68gu6ZL06VFv9/j3wzc78bVGeXhwt2Q+cI9hEwuQ883ZaxrleaA== ARC-Seal: i=1; s=key1; d=yhetil.org; t=1721906688; a=rsa-sha256; cv=none; b=mbKPJHTdTg8t9HeXxMBMNbdivyOw+wZikwfPXF3R3HI79mH7dixw9OrA7gV3z+o/HcFFd8 cxWSv61D3Q+onnrsUIwsdKGeu8r3h8WiNw+gbtKZNUUn8e4X86aIiJuNPIbfs3sxR56Mlm ADEOSzcxXHoHawGFY49ym2kR+PYNyMpCAoOmBxx2owTXtzeob2VRAdoVmoNdgxJ1SBqiOE 9fdZiK8ek+dVbbp36lVHyfj5ZRYl4Tfuel/Dhod5B3shJKC4QYdDq0PrdpiWj4yaOIwmlY wD4hfkIiiaNaLoRiQz0C+wZ+m91mA4/9xCYFXzD6HoOc/5XLEkycqjAeARd59w== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("body hash did not verify") header.d=tethera.net header.s=2024 header.b=XgOQaQG4; dmarc=none; spf=pass (aspmx1.migadu.com: domain of notmuch-bounces@notmuchmail.org designates 135.181.149.255 as permitted sender) smtp.mailfrom=notmuch-bounces@notmuchmail.org Received: from mail.notmuchmail.org (yantan.tethera.net [135.181.149.255]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4E6591B3CE for ; Thu, 25 Jul 2024 13:24:48 +0200 (CEST) Received: from yantan.tethera.net (localhost [127.0.0.1]) by mail.notmuchmail.org (Postfix) with ESMTP id 040C35F4A9; Thu, 25 Jul 2024 11:24:46 +0000 (UTC) Received: from phubs.tethera.net (phubs.tethera.net [192.99.9.157]) by mail.notmuchmail.org (Postfix) with ESMTPS id A41195F3A4 for ; Thu, 25 Jul 2024 11:24:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tethera.net; i=@tethera.net; q=dns/txt; s=2024; t=1721906679; h=from : to : cc : subject : in-reply-to : references : date : message-id : mime-version : content-type : from; bh=PKaQNuTny+3664/VhP1ThO7z3bSd3apooTWPuDQNXaA=; b=XgOQaQG4nh3eFjLAESSPPJqXYDY0vgyWBvOXPiTtYiwsLtJPja7bZnK9D/DRHZebgE0HP vXJB5PLORoKMqqYF3oncSNTjY3yu0TeTVQq7IRWQi//A/Y7mHrMbAk06F3g86UC2R/nqgJH mEwAEDUIDXY8FbNv7KhHlHNtknMfaCGeJvlx1X5+EXyim2aKb8brF3H9ONlEWvAD3FzB9lO eEVAXB3t+rWIF2kO7k2Igxu9Im68xwUXqm2GA2dj5dxmaqRh4xarWs8+kBT+Hyw7p/J8EPK uO1ZNqWUPYYzDKFR0rLbbUoD/Qa1dVwOu+hZ4iqdOLiyQObIOJSszv5wDIlQ== Received: from tethera.net (unknown [210.110.131.58]) by phubs.tethera.net (Postfix) with ESMTPS id 9458A18006E; Thu, 25 Jul 2024 08:24:38 -0300 (ADT) Received: (nullmailer pid 498737 invoked by uid 1000); Thu, 25 Jul 2024 11:24:35 -0000 From: David Bremner To: Sandra Snan , notmuch@notmuchmail.org Subject: Re: [PATCH 1/2] Add notmuch-search-unthread-thread In-Reply-To: <20231207170247.504315-1-sandra.snan@idiomdrottning.org> References: <20231207170247.504315-1-sandra.snan@idiomdrottning.org> Date: Thu, 25 Jul 2024 20:24:35 +0900 Message-ID: <87y15piuj0.fsf@tethera.net> MIME-Version: 1.0 Message-ID-Hash: GPQOY3PA5RHQYITYAYODPZIURQUABLHN X-Message-ID-Hash: GPQOY3PA5RHQYITYAYODPZIURQUABLHN X-MailFrom: david@tethera.net X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; emergency; loop; banned-address; member-moderation; header-match-notmuch.notmuchmail.org-0; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header CC: Sandra Snan X-Mailman-Version: 3.3.3 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit X-Migadu-Flow: FLOW_IN X-Migadu-Country: DE X-Migadu-Queue-Id: 4E6591B3CE X-Migadu-Scanner: mx12.migadu.com X-Migadu-Spam-Score: -2.29 X-Spam-Score: -2.29 X-TUID: iNRHrzlE2M+o Sandra Snan writes: > + (interactive "P") > + (let ((thread-id (notmuch-search-find-thread-id))) > + (if thread-id > + (notmuch-unthreaded (if entire thread-id > + (concat notmuch-search-query-string " and " thread-id))) > + (message "No such thread with that id found!") > + nil))) > + Hi Sandra; This seems reasonable enough. Two questions 1) can you make a test (probably something in T465 can serve as a model 2) Should this be bound by default, or is the function in the next patch always the one users will want?