unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: David Bremner <david@tethera.net>
To: Sandra Snan <sandra.snan@idiomdrottning.org>, notmuch@notmuchmail.org
Cc: Sandra Snan <sandra.snan@idiomdrottning.org>
Subject: Re: [PATCH 1/2] Add notmuch-search-unthread-thread
Date: Thu, 25 Jul 2024 20:24:35 +0900	[thread overview]
Message-ID: <87y15piuj0.fsf@tethera.net> (raw)
In-Reply-To: <20231207170247.504315-1-sandra.snan@idiomdrottning.org>

Sandra Snan <sandra.snan@idiomdrottning.org> writes:

> +  (interactive "P")
> +  (let ((thread-id (notmuch-search-find-thread-id)))
> +    (if thread-id
> +	(notmuch-unthreaded (if entire thread-id
> +			      (concat notmuch-search-query-string " and " thread-id)))
> +      (message "No such thread with that id found!")
> +      nil)))
> +

Hi Sandra;

This seems reasonable enough. Two questions

1) can you make a test (probably something in T465 can serve as a model

2) Should this be bound by default, or is the function in the next patch
always the one users will want?

      parent reply	other threads:[~2024-07-25 11:24 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-07 17:02 [PATCH 1/2] Add notmuch-search-unthread-thread Sandra Snan
2023-12-07 17:02 ` [PATCH 2/2] Add notmuch-search-show-or-unthread Sandra Snan
2024-07-25 11:32   ` David Bremner
2024-07-26  9:02     ` Sandra Snan
2024-07-29 11:04       ` David Bremner
2024-07-25 11:24 ` David Bremner [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87y15piuj0.fsf@tethera.net \
    --to=david@tethera.net \
    --cc=notmuch@notmuchmail.org \
    --cc=sandra.snan@idiomdrottning.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).