From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <cworth@cworth.org>
Received: from localhost (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 7E8FF431FC0;
	Wed, 18 Nov 2009 15:06:07 -0800 (PST)
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
Received: from olra.theworths.org ([127.0.0.1])
	by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id pEd0TkiwL2bo; Wed, 18 Nov 2009 15:06:07 -0800 (PST)
Received: from cworth.org (localhost [127.0.0.1])
	by olra.theworths.org (Postfix) with ESMTP id 6FDA2431FBC;
	Wed, 18 Nov 2009 15:06:06 -0800 (PST)
From: Carl Worth <cworth@cworth.org>
To: Alexander Botero-Lowry <alex.boterolowry@gmail.com>, Keith Packard
	<keithp@keithp.com>, notmuch@notmuchmail.org
In-Reply-To: <1258532999-9316-1-git-send-email-keithp@keithp.com>
References: <1258532999-9316-1-git-send-email-keithp@keithp.com>
	<867hto2p0t.fsf@fortitudo.i-did-not-set--mail-host-address--so-tickle-me>
Date: Thu, 19 Nov 2009 00:05:51 +0100
Message-ID: <87ws1nmo1c.fsf@yoom.home.cworth.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Subject: Re: [PATCH] Create a default notmuch-show-hook that highlights URLs
 and uses word-wrap
X-BeenThere: notmuch@notmuchmail.org
X-Mailman-Version: 2.1.12
Precedence: list
List-Id: "Use and development of the notmuch mail system."
	<notmuch.notmuchmail.org>
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
List-Archive: <http://notmuchmail.org/pipermail/notmuch>
List-Post: <mailto:notmuch@notmuchmail.org>
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
	<mailto:notmuch-request@notmuchmail.org?subject=subscribe>
X-List-Received-Date: Wed, 18 Nov 2009 23:06:07 -0000

On Wed, 18 Nov 2009 00:29:59 -0800, Keith Packard <keithp@keithp.com> wrote:
> I created the notmuch-show-hook precisely so I could add these two
> options, but I suspect most people will want them, so I just made them
> the default. If you don't want them, you can use remove-hook to get
> rid of this.

Thanks, Keith!

I had actually held off on pushing your original commit to add the hook
because I didn't like that it wasn't documenting what the hook was good
for. But now that we've got some good, suggested behavior there, I'm
much happier. So both are pushed now.

On Wed, 18 Nov 2009 00:52:34 -0800, Alexander Botero-Lowry <alex.boterolowry@gmail.com> wrote:
> Yes, hooks should be added for search as well. :)

Not a bad idea at all.

> visual-line-mode turns out to make subject look pretty ugly if there is a
> continuation. It doesn't do much good for the citation headers
> either. We probably need to do our own intelligent wrapping rather then
> use visual-line-mode to make this actually look right.

Yes, this stuff isn't perfect yet, but I think it's better than nothing.
We can do our own wrapping if these things get too annoying.

-Carl