From: Jesse Rosenthal <jrosenthal@jhu.edu>
To: Sebastian Spaeth <Sebastian@SSpaeth.de>,
Notmuch development list <notmuch@notmuchmail.org>
Subject: Re: sort order regression
Date: Thu, 22 Apr 2010 10:14:16 -0400 [thread overview]
Message-ID: <87wrvz7ex3.fsf@jhu.edu> (raw)
In-Reply-To: <87bpdbmvj0.fsf@SSpaeth.de>
On Thu, 22 Apr 2010 16:06:27 +0200, Sebastian Spaeth <Sebastian@SSpaeth.de> wrote:
>
> jkr and I noticed that patch series are shown in reverse order now, in
> fact threads seem to display messages at the same depth in reverse
> chronological order now.
Just to follow up on this, it seems that the regression comes from the
fix Carl introduced in 2a1a4f0551 to make his simplification of my patch
(simplification = 36e4459a3 , my patch = 4971b85641) pass tests. The
question is whether my original, more complicated version would have
passed the tests without the regressing fix. I do know that it showed
the search order as expected.
Unfortunately, I'm not quite skilled enough at git to turn back some
files to a certain state, tests to another state, and so on.
Best,
Jesse
next prev parent reply other threads:[~2010-04-22 14:14 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-22 14:06 sort order regression Sebastian Spaeth
2010-04-22 14:14 ` Jesse Rosenthal [this message]
2010-04-22 14:21 ` Jesse Rosenthal
2010-04-22 14:31 ` Jesse Rosenthal
2010-04-22 21:10 ` Carl Worth
2010-04-23 7:28 ` Sebastian Spaeth
2010-04-23 8:15 ` Michal Sojka
2010-04-23 15:18 ` Carl Worth
2010-04-26 9:59 ` Michal Sojka
2010-04-26 15:05 ` Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wrvz7ex3.fsf@jhu.edu \
--to=jrosenthal@jhu.edu \
--cc=Sebastian@SSpaeth.de \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).