unofficial mirror of notmuch@notmuchmail.org
 help / color / mirror / code / Atom feed
From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org
Subject: Re: [PATCH 10/10] test: use emacsclient(1) for Emacs tests
Date: Wed, 29 Jun 2011 02:22:31 +0400	[thread overview]
Message-ID: <87wrg5wq8o.fsf@gmail.com> (raw)
In-Reply-To: <87hb798uz7.fsf@yoom.home.cworth.org>

On Tue, 28 Jun 2011 15:14:04 -0700, Carl Worth <cworth@cworth.org> wrote:
> On Tue, 28 Jun 2011 08:45:11 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
> > Before the change, every Emacs test ran in a separate Emacs
> > instance.  Starting Emacs many times wastes considerable time and
> > it gets worse as the test suite grows.  The patch solves this by
> > using a single Emacs server and emacsclient(1) to run multiple
> > tests. 
> 
> Great, great stuff, Dmitry!
> 
> I've pushed everything earlier than this patch in this series.
> 
> And I'd be fine pushing this one as well, (if Austin cares strongly
> about not polling, I'll invite him to improve things from here).
> 
> Except that things don't actually work for me with this patch applied.
> 
> I'm not getting consistent results from the test suite, (I have seen
> both "2 tests failed" and "5 tests failed"). Here are the failures from
> a recent run with 5 failures:
> 
>  FAIL   decryption, --format=text
>  FAIL   decryption, --format=json
>  FAIL   decryption, --format=json, --part=4
>  FAIL   decrypt attachment (--part=5 --format=raw)
>  FAIL   decryption failure with missing key
> 
> In each case the actual output was either empty, or an empty JSON
> array. In some cases notmuch also gave an error:
> 
> Error: search term did not match precisely one message.
> 
> Are you not getting these same failures?
> 

Ouch.  I never saw these.  Do you get these in crypto tests only?

Regards,
  Dmitry

> Let me know what else I can do to investigate this.
> 
> -Carl
> 
> -- 
> carl.d.worth@intel.com

  reply	other threads:[~2011-06-28 22:22 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-06-28  4:45 [PATCH 01/10] test: fix argument order of test_expect_equal_file in few tests Dmitry Kurochkin
2011-06-28  4:45 ` [PATCH 02/10] test: do not set `message-signature' in test_emacs Dmitry Kurochkin
2011-06-28  4:45 ` [PATCH 03/10] test: cleanup test_emacs Dmitry Kurochkin
2011-06-28  4:45 ` [PATCH 04/10] test: wrap and indent test_emacs calls Dmitry Kurochkin
2011-06-28  4:45 ` [PATCH 05/10] test: save buffer content to file instead of printing it in Emacs tests Dmitry Kurochkin
2012-01-23  4:26   ` [PATCH] test/emacs-large-search-buffer: correct typo (EXPEXTED -> EXPECTED) Pieter Praet
2012-01-23 11:48     ` David Bremner
2011-06-28  4:45 ` [PATCH 06/10] test: remove some sed(1) calls in Emacs tests Dmitry Kurochkin
2011-06-28  4:45 ` [PATCH 07/10] test: use emacs_deliver_message in Emacs SMTP send test Dmitry Kurochkin
2011-06-28  4:45 ` [PATCH 08/10] test: set variables using `let' instead of `setq' in Emacs tests Dmitry Kurochkin
2012-01-23 19:05   ` Xavier Maillard
2011-06-28  4:45 ` [PATCH 09/10] test: generate run_emacs script once on test startup Dmitry Kurochkin
2011-06-28  4:45 ` [PATCH 10/10] test: use emacsclient(1) for Emacs tests Dmitry Kurochkin
2011-06-28  4:56   ` [PATCH] " Dmitry Kurochkin
2011-06-28 22:14   ` [PATCH 10/10] " Carl Worth
2011-06-28 22:22     ` Dmitry Kurochkin [this message]
2011-06-29  0:15       ` Carl Worth
2011-06-29  7:34         ` Austin Clements
2011-06-29 14:20           ` Carl Worth
2012-01-23 19:08   ` Xavier Maillard
2012-01-25  0:47     ` Pieter Praet
2012-01-25  1:01     ` David Bremner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://notmuchmail.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87wrg5wq8o.fsf@gmail.com \
    --to=dmitry.kurochkin@gmail.com \
    --cc=cworth@cworth.org \
    --cc=notmuch@notmuchmail.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://yhetil.org/notmuch.git/

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).