From: Carl Worth <cworth@cworth.org>
To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
Cc: amdragon@mit.edu
Subject: Re: [PATCH 1/2] new: Don't update DB mtime if FS mtime equals wall-clock time.
Date: Wed, 29 Jun 2011 06:47:37 -0700 [thread overview]
Message-ID: <87wrg4696u.fsf@yoom.home.cworth.org> (raw)
In-Reply-To: <1309331455-19584-1-git-send-email-amdragon@mit.edu>
[-- Attachment #1: Type: text/plain, Size: 1000 bytes --]
On Wed, 29 Jun 2011 03:10:54 -0400, Austin Clements <amdragon@MIT.EDU> wrote:
> This fixes a race where multiple message deliveries in the same second
> with an intervening notmuch new could result in messages being ignored
> by notmuch (at least, until a later delivery forced a rescan).
Thanks for the fix, Austin!
> + * XXX Bug workaround: If this is a new directory, we *must*
> + * update the mtime; otherwise the next run will see the 0 mtime
> + * and think this is still a new directory containing no files or
> + * subdirs (which is unsound in general). If fs_mtime ==
> + * stat_time, we set the database mtime to a bogus (but non-zero!)
> + * value to force a rescan.
I like to reserve "XXX" as an indication that some further work is
necessary.
That doesn't seem to be the case here, (instead, you seem to have
thought this issue out quite fully).
Other than that, I'm quite happy with the patch.
-Carl
--
carl.d.worth@intel.com
[-- Attachment #2: Type: application/pgp-signature, Size: 197 bytes --]
next prev parent reply other threads:[~2011-06-29 13:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-06-29 7:10 [PATCH 1/2] new: Don't update DB mtime if FS mtime equals wall-clock time Austin Clements
2011-06-29 7:10 ` [PATCH 2/2] test: Nix increment_mtime Austin Clements
2011-06-29 13:47 ` Carl Worth [this message]
2011-06-29 14:41 ` [PATCH 1/2] new: Don't update DB mtime if FS mtime equals wall-clock time Carl Worth
2011-06-29 22:35 ` Carl Worth
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://notmuchmail.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wrg4696u.fsf@yoom.home.cworth.org \
--to=cworth@cworth.org \
--cc=amdragon@MIT.EDU \
--cc=notmuch@notmuchmail.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://yhetil.org/notmuch.git/
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).