From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id AA870431FD0 for ; Sat, 24 Dec 2011 00:06:14 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -0.799 X-Spam-Level: X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id VNsoOgZIIwND for ; Sat, 24 Dec 2011 00:06:14 -0800 (PST) Received: from mail-ww0-f41.google.com (mail-ww0-f41.google.com [74.125.82.41]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client certificate requested) by olra.theworths.org (Postfix) with ESMTPS id E0607431FB6 for ; Sat, 24 Dec 2011 00:06:13 -0800 (PST) Received: by wgbdt12 with SMTP id dt12so13256552wgb.2 for ; Sat, 24 Dec 2011 00:06:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:subject:in-reply-to:references:user-agent:date:message-id :mime-version:content-type; bh=NV9ntzrCKJvfKwMtLtbZhfEDliI8VCJ3ZzHkxsQn1K8=; b=qu/orSRT0AW+s11fK2HWEljBYL5nvEdyo8r1bANnDV/l9CqJ+g6ieEiiEIstTI6oWg OL7PqsY3J36AtFEYJjY/zzOC/yaIVpcrKEGmjARLvQCMrB98KuYWE94lpfREJONv9f1V gplhJAs7GQpQ1FNRubdSerhEAosnHGiCY+HDA= Received: by 10.216.139.91 with SMTP id b69mr7818557wej.51.1324713966483; Sat, 24 Dec 2011 00:06:06 -0800 (PST) Received: from localhost ([91.144.186.21]) by mx.google.com with ESMTPS id 1sm38306320wiz.11.2011.12.24.00.06.04 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 24 Dec 2011 00:06:05 -0800 (PST) From: Dmitry Kurochkin To: Jameson Graef Rollins , Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH v4 2/4] Introduce a generic tree-like abstraction for MIME traversal. In-Reply-To: <87y5u2jte1.fsf@servo.finestructure.net> References: <1323460468-4030-1-git-send-email-amdragon@mit.edu> <1324698348-27620-1-git-send-email-amdragon@mit.edu> <1324698348-27620-3-git-send-email-amdragon@mit.edu> <87y5u2jte1.fsf@servo.finestructure.net> User-Agent: Notmuch/0.10.2+116~g4c449d4 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 24 Dec 2011 12:05:21 +0400 Message-ID: <87wr9mjsxq.fsf@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2011 08:06:14 -0000 On Fri, 23 Dec 2011 23:55:34 -0800, Jameson Graef Rollins wrote: > On Fri, 23 Dec 2011 22:45:46 -0500, Austin Clements wrote: > > + /* True if decryption of this part was attempted. */ > > + notmuch_bool_t decrypt_attempted; > > + /* True if decryption of this part's child succeeded. In this > > + * case, the decrypted part is substituted for the second child of > > + * this part (which would usually be the encrypted data). */ > > + notmuch_bool_t decrypt_success; > > + > > + /* True if signature verification on this part was attempted. */ > > + notmuch_bool_t sig_attempted; > > I think these new variables make sense, and reflect the correct > semantics, as you already mentioned. > > I do, however, think the later variable should be called > "verify_attempted" (or "verification_", or "ver_"?), instead of > "sig_attempted", since verification is the complementary action on a > signed part, just as decryption is for an encrypted one. > "sig_attempted" somehow implies to me that one is trying to make a > signature, not verify an existing one. > I agree, verify_attempted seems to be consistent with decrypt_attempted. Please, do not make it "ver_", it is easy associated with version. I guess I prefer long clear names in general, do not mind pushing few more buttons... Regards, Dmitry > jamie. > _______________________________________________ > notmuch mailing list > notmuch@notmuchmail.org > http://notmuchmail.org/mailman/listinfo/notmuch