From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from localhost (localhost [127.0.0.1]) by olra.theworths.org (Postfix) with ESMTP id E61AB421171 for ; Sat, 14 Jan 2012 15:40:31 -0800 (PST) X-Virus-Scanned: Debian amavisd-new at olra.theworths.org X-Spam-Flag: NO X-Spam-Score: -2.29 X-Spam-Level: X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled Received: from olra.theworths.org ([127.0.0.1]) by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id zGqpXEex7yjL for ; Sat, 14 Jan 2012 15:40:31 -0800 (PST) Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu [131.215.239.19]) by olra.theworths.org (Postfix) with ESMTP id 75D07421167 for ; Sat, 14 Jan 2012 15:40:31 -0800 (PST) Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1]) by fire-doxen-postvirus (Postfix) with ESMTP id 1D3C02E50D93; Sat, 14 Jan 2012 15:40:31 -0800 (PST) X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new Received: from finestructure.net (cpe-76-174-137-84.socal.res.rr.com [76.174.137.84]) (Authenticated sender: jrollins) by fire-doxen-submit (Postfix) with ESMTP id 517342E507DB; Sat, 14 Jan 2012 15:40:27 -0800 (PST) Received: by finestructure.net (Postfix, from userid 1000) id BCF6232B; Sat, 14 Jan 2012 15:40:26 -0800 (PST) From: Jameson Graef Rollins To: Austin Clements , notmuch@notmuchmail.org Subject: Re: [PATCH v2 3/3] search: Support automatic tag exclusions In-Reply-To: <1326496024-14403-4-git-send-email-amdragon@mit.edu> References: <1326258173-21163-1-git-send-email-amdragon@mit.edu> <1326496024-14403-1-git-send-email-amdragon@mit.edu> <1326496024-14403-4-git-send-email-amdragon@mit.edu> User-Agent: Notmuch/0.11+63~g6965a07 (http://notmuchmail.org) Emacs/23.3.1 (x86_64-pc-linux-gnu) Date: Sat, 14 Jan 2012 15:40:26 -0800 Message-ID: <87wr8tsvit.fsf@servo.finestructure.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-BeenThere: notmuch@notmuchmail.org X-Mailman-Version: 2.1.13 Precedence: list List-Id: "Use and development of the notmuch mail system." List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Jan 2012 23:40:32 -0000 --=-=-= This patch looks fine. Philosophical UI discussion to follow: On Fri, 13 Jan 2012 18:07:04 -0500, Austin Clements wrote: > + if (notmuch_config_get_auto_exclude_tags (config, &tmp) == NULL) { > + const char *tags[] = { "deleted", "spam" }; > + notmuch_config_set_auto_exclude_tags (config, tags, 2); > + } This creates the config section with the exclude list pre-set to "deleted;spam". I personally have no problem with this, since I was going to be setting exactly that anyway. However, assuming we decide to have this be the default in the CLI, should we therefore add support for it in the emacs UI? I've been going back and forth on this (as readers are well aware), and have most recently rejected the idea that we should add delete support to the emacs UI. However, if we are excluding "deleted" tags by default, then I'm going to go back and say that we should include the keybindings to "delete" messages. Comments? If people think we should exclude "deleted;spam" by default, and agree that we should also add delete support in the emacs UI, I'll go ahead and rework my keybinding patches. jamie. --=-=-= Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1.4.11 (GNU/Linux) iQIcBAEBCAAGBQJPEhJqAAoJEO00zqvie6q8S/UP/AzPEQQRINYv4wK0s910UZmC WhCkeYdeydsKHwBKtETnUF0QNa10wJO+SiQfeffs0BCc28jR9U3NIi32WkIHuvcM 1JzOcG4AY4lfqN8laJQgrKWbDnXrRnLw0bS0DYx2wDGacq2JEEa4xOVsjIp9styX keHfVtfTaJ1l2bWQsXeVNUw99DpbGAn3JYnrDRDy7AaQiaa5DUk3NAdrn+vj9hla ccMOfeGwLmFRe98EgBN4LjWotjmE09s0EoyLGh+M5c2bK81zO0ZcvQth6FSjDfjr bZMSxwlYhq6ACG7/o+mN0+yMiDzxA8K/P0fEZ2XsNXPrAPBNcNu1efDpcPbm+xbH 0rXQFN1YN1v1cIvnXi/B4f6X8qfkBdtKput32aCXuge6T4/WuNvt743uXw2DLZvt O2Yi5QcJA51oZcaKsPiqEXQ3IijwM5e0z3xFFGCnZFJpNEUkKyKieNBE/I5ty2n3 y3bEKpWvCB7dbxy4nQnul0EuNNcJshPyMeLSwFV2Y0pxf9pTfvt+y66K1WwgjnCF 9o/YTd/uKUuFNDJ+BibltYUWm4GbMfo8WuybMHuqMOETPHw2lya/PpW7LaS+pJcD 2tvkcjAHrj2bhqCljb0A8RWb1sYBIlMsTnCtA1DAWuB+ceaycwLO8VCH6hcznBlr BRI+dnjIFMId5K7Qh0Zt =a6Yk -----END PGP SIGNATURE----- --=-=-=--